-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log node name when error attaching volume #45042
Conversation
Hi @wongma7. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
btw @gnufied this doesnt fix the trello card, i just noticed this inconsistency since other plugins say 'failed to attach to 'instanceid' or whatever. |
I'd expect that message to bubble up more "normally" in an error flow, but that's prexisting and volumes have always been unusual. Looks like a positive move. /lgtm |
@k8s-bot ok to test |
lgtm. someone also needs to approve it though |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, thockin, wongma7
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
Helps with debugging to know immediately which node the volume failed to atach to. Went through all plugins, added this to 3. @gnufied