Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #45055 #45068

Merged
merged 1 commit into from
May 9, 2017
Merged

Automated cherry pick of #45055 #45068

merged 1 commit into from
May 9, 2017

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Apr 28, 2017 •
edited

Cherry pick of #45055 on release-1.6.

#45055: Bump GLBC version to 0.9.3

Release note:

Bump GLBC version to 0.9.3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2017
@nicksardo
Copy link
Contributor Author

@k8s-bot node e2e test this
@k8s-bot gce etcd3 e2e test this

@nicksardo
Copy link
Contributor Author

@k8s-bot node e2e test this

@nicksardo nicksardo mentioned this pull request Apr 28, 2017
Merged
@nicksardo
Copy link
Contributor Author

nicksardo commented Apr 28, 2017 •
edited

Node test failing in other 1.6 cherry picks as well. #45083 (comment)

@nicksardo
Copy link
Contributor Author

/assign @mwielgus

@nicksardo
Copy link
Contributor Author

@k8s-bot node e2e test this

1 similar comment
@nicksardo
Copy link
Contributor Author

@k8s-bot node e2e test this

@dchen1107 dchen1107 mentioned this pull request May 1, 2017
Merged
@dchen1107
Copy link
Member

I quickly looked into all failures in #45068, #45121 and #45083, and the all volume related tests failed because volume cannot be gc properly, thus pod cannot be deleted.

I believe we hit a known issue: #43534 which is triggered by bumping to go1.8 (#41636)

@nicksardo
Copy link
Contributor Author

@k8s-bot node e2e test this

@nicksardo
Copy link
Contributor Author

@mwielgus Tests have been fixed - can you please set the appropriate cherry pick label and 1.6 milestone? Thanks

@dchen1107 dchen1107 added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 1, 2017
@nicksardo
Copy link
Contributor Author

/assign @enisoc
/unassign @mikedanese @jbeda

@k8s-ci-robot k8s-ci-robot assigned enisoc and unassigned jbeda and mikedanese May 8, 2017
@enisoc enisoc added this to the v1.6 milestone May 8, 2017
@enisoc enisoc added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 8, 2017
@enisoc
Copy link
Member

enisoc commented May 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enisoc, nicksardo
We suggest the following additional approver: eparis

Assign the PR to them by writing /assign @eparis in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8118c50 into kubernetes:release-1.6 May 9, 2017
@fejta fejta mentioned this pull request May 11, 2017
Closed
@nicksardo nicksardo deleted the automated-cherry-pick-of-#45055-upstream-release-1.6 branch January 12, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nicksardo @k8s-reviewable @dchen1107 @enisoc @k8s-github-robot @jbeda @mikedanese @mwielgus @k8s-ci-robot