Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glusterfs vendor dependencies to sha@7a54b6fc903feab1e7cb65731… #45081

Merged
merged 2 commits into from
May 4, 2017

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 28, 2017

…77ca09b544eb1e2

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Apr 28, 2017
@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 28, 2017
@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2017

@jsafrane @rootfs PTAL.

@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2017

/assign @jsafrane @rootfs :)

@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2017
@k8s-ci-robot
Copy link
Contributor

@humblec: you can't request testing unless you are a kubernetes member.

In response to this:

@k8s-bot ok to test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Member

@k8s-bot ok to test

@rootfs
Copy link
Contributor

rootfs commented Apr 28, 2017

@humblec any detail about this update?

@humblec humblec force-pushed the glusterfs-vendor-update branch 2 times, most recently from 8583062 to bcc3569 Compare May 2, 2017 04:55
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec force-pushed the glusterfs-vendor-update branch 5 times, most recently from f551152 to 8b715ee Compare May 2, 2017 06:24
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented May 2, 2017

@rootfs heketi version 4 (https://github.com/heketi/heketi/releases/ was released some time back with few enhancements and bug fixes . The reason behind this specific commit which is after v4 is mainly because there is an api change due to a new member in brickinfo struct.

@@ -66,6 +62,7 @@ type BrickInfo struct {
        Path     string `json:"path"`
        DeviceId string `json:"device"`
        NodeId   string `json:"node"`
+       VolumeId string `json:"volume"`

@humblec
Copy link
Contributor Author

humblec commented May 2, 2017

/assign @rootfs

@rootfs
Copy link
Contributor

rootfs commented May 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2017
@humblec
Copy link
Contributor Author

humblec commented May 4, 2017

@lavalamp @dchen1107 @wojtek-t @thockin Can any one of you approve this PR ? :)

@wojtek-t
Copy link
Member

wojtek-t commented May 4, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, rootfs, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a8cd27c into kubernetes:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants