Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #45031 #45083

Conversation

crassirostris
Copy link

Cherry pick of #45031 on release-1.6.

#45031: Remove too verbose label from fluentd metrics

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@crassirostris crassirostris added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2017
@piosz
Copy link
Member

piosz commented Apr 28, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@crassirostris
Copy link
Author

@k8s-bot node e2e test this

1 similar comment
@crassirostris
Copy link
Author

@k8s-bot node e2e test this

@crassirostris
Copy link
Author

Well I don't know what's wrong with this test, but it's certainly not this PR's fault

@fejta FYI

@fejta
Copy link
Contributor

fejta commented Apr 28, 2017

Well the job is definitely failing (and consistently to boot) so I don't see anything for me to do.

Node suite is node team and namespace issues are api machinery. Contact them if you think the results are wrong? (Dawn or Daniel)

@crassirostris
Copy link
Author

It's passed in the original PR: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/45031/pull-kubernetes-node-e2e/27384/

@dchen1107 @lavalamp Have you seen this issue? Are those just flakes?

@dchen1107
Copy link
Member

I quickly looked into all failures in #45068, #45121 and #45083, and the all volume related tests failed because volume cannot be gc properly, thus pod cannot be deleted.

I believe we hit a known issue: #43534 which is triggered by bumping to go1.8 (#41636)

@MrHohn
Copy link
Member

MrHohn commented May 1, 2017

@ixdy Here is the node e2e failure

@dchen1107
Copy link
Member

Checked build.log with more detail:

W0428 03:59:39.616] Run: ('docker', 'pull', 'gcr.io/k8s-testimages/kubekins-node:1.7-latest')
I0428 03:59:39.989] 1.7-latest: Pulling from k8s-testimages/kubekins-node
I0428 03:59:39.990] Digest: sha256:b3cc9993ddfb862bc7c7075f7cbd37fdbefbf3096df3a94ff2da4c2957517d2c
I0428 03:59:39.990] Status: Image is up to date for gcr.io/k8s-testimages/kubekins-node:1.7-latest

kubekins-node:1.7-latest was introduced through PR: https://github.com/kubernetes/test-infra/pull/2521/files

This proves the theory I had at #45083 (comment)

@ixdy
Copy link
Member

ixdy commented May 1, 2017

oops, small bug, easy fix in kubernetes/test-infra#2624.

@ixdy
Copy link
Member

ixdy commented May 1, 2017

@k8s-bot node e2e test this

@crassirostris
Copy link
Author

@dchen1107 @ixdy Thanks a lot!

@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 8, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b2af683 into kubernetes:release-1.6 May 8, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet