Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and minor cleanups to pod (anti)affinity predicate #45098

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Fixes and minor cleanups to pod (anti)affinity predicate #45098

merged 1 commit into from
Apr 29, 2017

Conversation

wojtek-t
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 28, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2017
@bsalamat
Copy link
Member

/lgtm

Thanks, @wojtek-t!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

@k8s-bot unit test this

@wojtek-t
Copy link
Member Author

@bsalamat - thanks; though to be clear, this is not fixing the main issue we were discussing, it's still not debugged

@bsalamat
Copy link
Member

Yes, I am aware that this is not addressing that issue.

@davidopp
Copy link
Member

LGTM

@k82cn
Copy link
Member

k82cn commented Apr 29, 2017

LGTM.

@k82cn
Copy link
Member

k82cn commented Apr 29, 2017

btw, it seems the unit test did not check this issue. Should we add one for it? I can help to create PR to update unit test as a follow up.

@davidopp
Copy link
Member

Sure, if you can create a test case for it that would be great.

@wojtek-t
Copy link
Member Author

@k8s-bot bazel test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ef4b4ac into kubernetes:master Apr 29, 2017
@k82cn k82cn mentioned this pull request Apr 30, 2017
Merged
@k82cn
Copy link
Member

k82cn commented Apr 30, 2017

#45152 was created for unit test of this fix.

k8s-github-robot pushed a commit that referenced this pull request May 2, 2017
Merge pull request #45152 from k82cn/ut_4_45098
30cbdc0 
Automatic merge from submit-queue (batch tested with PRs 45100, 45152, 42513, 44796, 45222)

Added InterPodAffinity unit test case with Namespace.

**What this PR does / why we need it**:
Added InterPodAffinity unit test case with Namespace: unit test case for #45098

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A

**Release note**:

```release-note-none
```
k8s-github-robot referenced this pull request May 5, 2017
Merge pull request #45352 from wojtek-t/automated-cherry-pick-of-#450…
47e4d7c 
…98-upstream-release-1.6

Automatic merge from submit-queue

Fixes and minor cleanups to pod (anti)affinity predicate

@davidopp @bsalamat
@wojtek-t wojtek-t mentioned this pull request May 8, 2017
Merged
@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 8, 2017
@wojtek-t wojtek-t deleted the fix_scheduler_pod_affinity branch May 23, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wojtek-t @k8s-reviewable @bsalamat @k8s-github-robot @davidopp @k82cn @enisoc @k8s-ci-robot