Run SSH e2e test only if SSH keys are present #45165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
ncdc
reviewed
May 1, 2017
test/e2e/framework/util.go
Outdated
| @@ -315,6 +315,13 @@ func SkipIfProviderIs(unsupportedProviders ...string) { | |||
| } | |||
| } | |||
|
|
|||
| func SkipUnlessSSHKeyPresent() { | |||
| _, err := GetSigner(TestContext.Provider) | |||
There was a problem hiding this comment.
if _, err := GetSigner(TestContext.Provider); err != nil {
dims
force-pushed
the
run-ssh-test-only-if-key-present
branch
from
ec540b4
to
bcdcf9e
Compare
Not all CI systems support ssh keys to be present on the node. This supports the case where "local" provider is being used when running e2e test, but the environment does not have a SSH key.
dims
force-pushed
the
run-ssh-test-only-if-key-present
branch
from
bcdcf9e
to
5cd700a
Compare
dims
changed the title
dims
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, fejta
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 44062, 45165) |
|
@dims PR needs rebase |
k8s-github-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Not all CI systems support ssh keys to be present on the node. This
supports the case where "local" provider is being used when running
e2e test, but the environment does not have a SSH key.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: