CRI: remove PodSandboxStatus.Linux.Namespaces.Network #45166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XS
|
@k8s-bot verify test this |
feiskyer
force-pushed
the
namespace-network
branch
from
787cb2c
to
c5d13ee
Compare
k8s-github-robot
added
needs-rebase
feiskyer
force-pushed
the
namespace-network
branch
from
c5d13ee
to
d301f22
Compare
k8s-github-robot
added
size/XL
|
Rebased. |
| @@ -338,8 +338,6 @@ message PodSandboxNetworkStatus { | |||
|
|
|||
| // Namespace contains paths to the namespaces. | |||
| message Namespace { | |||
| // Path to the network namespace. | |||
| string network = 1; | |||
| // Namespace options for Linux namespaces. | |||
| NamespaceOption options = 2; | |||
There was a problem hiding this comment.
We can't change this number to 1, right?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, feiskyer
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 45013, 45166) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PodSandboxStatus.Linux.Namespaces.Network is not used, so this PR removes it from CRI.
Which issue this PR fixes
Closes: #44972
Special notes for your reviewer:
Release note:
/assign @Random-Liu @yujuhong