Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying cluster signing ca/key #45177

Merged
merged 1 commit into from
May 2, 2017
Merged

Allow specifying cluster signing ca/key #45177

merged 1 commit into from
May 2, 2017

Conversation

dims
Copy link
Member

@dims dims commented May 1, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 1, 2017
@fejta
Copy link
Contributor

fejta commented May 1, 2017

/unassign @fejta @spxtr
/assign @dims

Please reassign once this is ready for review!

@k8s-ci-robot k8s-ci-robot assigned dims and unassigned fejta and spxtr May 1, 2017
@dims
Allow specifying cluster signing ca/key
ec44cc2 
Makes it useful in testing some scenarios with automatically
signing certificates
@dims dims force-pushed the allow-cluster-signing-ca-crt-and-key branch from d36d557 to ec44cc2 Compare May 1, 2017 23:28
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2017
@dims dims changed the title [WIP] Allow specifying cluster signing ca/key Allow specifying cluster signing ca/key May 1, 2017
@dims
Copy link
Member Author

dims commented May 1, 2017

/assign @fejta @spxtr

@fejta
Copy link
Contributor

fejta commented May 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, fejta

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 1, 2017
@fejta fejta added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels May 1, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45077, 45180, 34727, 45079, 45177)

@k8s-github-robot k8s-github-robot merged commit 29f37fd into kubernetes:master May 2, 2017
@dims dims deleted the allow-cluster-signing-ca-crt-and-key branch November 16, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@fejta fejta

@spxtr spxtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @k8s-reviewable @fejta @k8s-github-robot @spxtr @k8s-ci-robot