Clean up code in dockertools #45199
Merged
Clean up code in dockertools #45199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we exported many constants and functions in dockertools to share with the dockershim package. This change moves such constants/functions to dockershim and unexport them. This change involves only mechnical changes and should not have any functional impact.
yujuhong
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
approved
feiskyer
reviewed
May 2, 2017
| @@ -16,38 +16,8 @@ limitations under the License. | |||
|
|
|||
| package dockertools | |||
|
|
|||
There was a problem hiding this comment.
Also remove other files inside dockertools?
There was a problem hiding this comment.
There will be more PRs to clean up the package. Can't really pack them all in one PR.
yujuhong
added
the
kind/cleanup
3 tasks
|
@feiskyer @Random-Liu these are mostly mechanical changes. More PRs will be uploaded to clean up the rest of the files. |
|
LGTM. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move functions and sub packages to dockershim.
Part of #43234.