Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver: split endpoint tests from client-go #45222

Merged
merged 1 commit into from
May 2, 2017
Merged

apiserver: split endpoint tests from client-go #45222

merged 1 commit into from
May 2, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 2, 2017 •
edited

Use the example apigroup and create its own scheme.

Fixes #45209.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@sttts sttts force-pushed the sttts-cut-off-endpoints-from-client-go branch from f419efe to a752415 Compare May 2, 2017 09:31
@sttts sttts force-pushed the sttts-cut-off-endpoints-from-client-go branch from a752415 to 67ca42b Compare May 2, 2017 10:04
@deads2k
Copy link
Contributor

deads2k commented May 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 2, 2017
@caesarxuchao
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 2, 2017
@caesarxuchao caesarxuchao removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 2, 2017
@caesarxuchao
Copy link
Member

Thanks a lot @sttts ! I didn't notice we had already copied pod definition to examples :)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45100, 45152, 42513, 44796, 45222)

@k8s-github-robot k8s-github-robot merged commit 2689f03 into kubernetes:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @k8s-reviewable @deads2k @k8s-github-robot @caesarxuchao @k8s-ci-robot