expose kubelet authentication and authorization builders #45238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k Assign the PR to them by writing
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
size/S
CaoShuFeng
reviewed
May 3, 2017
cmd/kubelet/app/auth.go
Outdated
| @@ -34,7 +34,7 @@ import ( | |||
| "k8s.io/kubernetes/pkg/kubelet/server" | |||
| ) | |||
|
|
|||
| func buildAuth(nodeName types.NodeName, client clientset.Interface, config componentconfig.KubeletConfiguration) (server.AuthInterface, error) { | |||
| func BuildAuth(nodeName types.NodeName, client clientset.Interface, config componentconfig.KubeletConfiguration) (server.AuthInterface, error) { | |||
There was a problem hiding this comment.
It's a public function now, so, do we need to add some comments?
|
doc, then LGTM |
deads2k
force-pushed
the
auth-04-expose-kubelet
branch
from
8f5b5ca
to
62dce5c
Compare
deads2k
force-pushed
the
auth-04-expose-kubelet
branch
from
62dce5c
to
0022223
Compare
deads2k
added
approved
|
Automatic merge from submit-queue (batch tested with PRs 45362, 45159, 45321, 45238) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubelet authentication and authorization builder methods are useful for consumers.
@liggitt