Use docker_bundle rule from new rules_docker repo #45248
Conversation
|
This change is |
k8s-ci-robot
added
the
cncf-cla: yes
|
We should probably review/merge kubernetes/repo-infra#17 and update that |
|
/assign @mikedanese @spxtr |
k8s-github-robot
added
size/M
|
/assign @thockin |
| symlinks = { | ||
| # Some cluster startup scripts expect to find the binaries in /usr/local/bin, | ||
| # but the debs install the binaries into /usr/bin. | ||
| "/usr/local/bin/" + binary: "/usr/bin/" + binary, | ||
| }, | ||
| ) for binary, meta in DOCKERIZED_BINARIES.items()] | ||
|
|
||
| [docker_bundle( | ||
| name = binary, | ||
| images = {"gcr.io/google_containers/%s:{STABLE_DOCKER_TAG}" % binary: binary + "-internal"}, |
There was a problem hiding this comment.
{STABLE_DOCKER_TAG}??? Does that actually work? We need this for debs and rpms.
There was a problem hiding this comment.
yep, with bazelbuild/rules_docker#17 :)
|
delete build/foo.tar |
|
ha, I have no idea how that even got there! :) |
WORKSPACE
Outdated
| ) | ||
|
|
||
| git_repository( | ||
| # This contains a patch to not prepend ./ to tarfiles produced by pkg_tar. | ||
| # When merged upstream, we'll no longer need to use ixdy's fork. |
There was a problem hiding this comment.
Can you link the CL that needs to merge here?
|
/approve |
k8s-github-robot
added
the
approved
… tools for pkg_tar
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, mikedanese, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 45283, 45289, 45248, 44295) |
What this PR does / why we need it: switched to using the new
docker_bundlerule fromrules_dockerinstead of my patcheddocker_buildrule. This also brings in some fixes for the docker rules that were missing from my fork.Additionally, I switched out the
git_repositoryrules forhttp_archiverules, since that seems to be recommended by the bazel docs (and might be faster).Lastly, I updated the
pkg_tarrules to use my patch, which doesn't prepend./to files inside the tarballs.This one should likely be merged upstream in the near future.
I think this is the last of the changes necessary to have
bazel run //:ci-artifactsworking properly to support using bazel for e2e in CI.Release note: