Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #45309 on release-1.6 #45383

Merged
merged 1 commit into from
May 5, 2017
Merged

Cherry pick #45309 on release-1.6 #45383

merged 1 commit into from
May 5, 2017

Conversation

yguo0905
Copy link
Contributor

@yguo0905 yguo0905 commented May 4, 2017

What this PR does / why we need it:

Cherry pick of #45309 on release-1.6.

This is needed to run Ubuntu node e2e tests on GKE. We want to cherry-pick them into the 1.6 release branch in order to run the tests against 1.6.

Release note:

NONE

/assign @dchen1107

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 4, 2017
@dchen1107 dchen1107 added this to the v1.6 milestone May 4, 2017
@dchen1107
Copy link
Member

Justification for 1.6 cherrypick: This is purely enable an alpha feature for GKE testing. It has no impact on OSS k8s.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yguo0905

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2017
@yguo0905
Copy link
Contributor Author

yguo0905 commented May 5, 2017

@k8s-bot gce etcd3 e2e test this

@calebamiles calebamiles removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 5, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 5, 2017
@calebamiles calebamiles added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 5, 2017
@calebamiles
Copy link
Contributor

removing do not merge label due to approval from @dchen1107.

cc: @yguo0905, @kubernetes/kubernetes-release-managers

@yguo0905
Copy link
Contributor Author

yguo0905 commented May 5, 2017

@k8s-bot node e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ab61393 into kubernetes:release-1.6 May 5, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@yguo0905 yguo0905 deleted the cherry-pick-45309-on-1.6 branch May 8, 2017 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yguo0905 @k8s-reviewable @k8s-github-robot @dchen1107 @calebamiles @k8s-cherrypick-bot @k8s-ci-robot