Fix and make TaintManager harder to break before we move it out of NC #45411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarek
added
the
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
approved
wojtek-t
reviewed
May 5, 2017
| @@ -314,6 +314,9 @@ func NewNodeController( | |||
| }) | |||
| nc.podInformerSynced = podInformer.Informer().HasSynced | |||
|
|
|||
| addNodeFunctions := []func(obj *v1.Node) error{} | |||
There was a problem hiding this comment.
As discussed offline, we should have multiple "AddEventHandlers" functions instead of this.
|
@k8s-bot bazel test this |
1 similar comment
|
@k8s-bot bazel test this |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmarek, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 45322, 44770, 45411) |
|
Thanks @gmarek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45342
cc @gyliu513