Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cni Log changes #45446

Merged
merged 1 commit into from
May 9, 2017
Merged

cni Log changes #45446

merged 1 commit into from
May 9, 2017

Conversation

zdj6373
Copy link
Contributor

@zdj6373 zdj6373 commented May 6, 2017

Newly modified log error, modified

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zdj6373. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 6, 2017
@danwinship
Copy link
Contributor

just a fix to a typo in a log message

/lgtm
/release-note-none
@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-label-needed labels May 8, 2017
@caseydavenport
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caseydavenport, danwinship, zdj6373
We suggest the following additional approver: freehan

Assign the PR to them by writing /assign @freehan in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zdj6373
Copy link
Contributor Author

zdj6373 commented May 9, 2017

/assign @freehan

1 similar comment
@danwinship
Copy link
Contributor

/assign @freehan

@freehan freehan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit aee07e9 into kubernetes:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danwinship danwinship

@freehan freehan

@caseydavenport caseydavenport

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zdj6373 @k8s-reviewable @k8s-ci-robot @danwinship @caseydavenport @k8s-github-robot @freehan