add validation for customresourcedefintions #45556
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/L
| ret := genericvalidation.NameIsDNSSubdomain(name, prefix) | ||
| requiredName := obj.Spec.Names.Plural + "." + obj.Spec.Group | ||
| if name != requiredName { | ||
| ret = append(ret, fmt.Sprintf(`must be spec.names.plural+"."+spec.group `)) |
| return allErrs | ||
| } | ||
|
|
||
| func ValidateCustomResourceNames(names *apiextensions.CustomResourceNames, fldPath *field.Path) field.ErrorList { |
There was a problem hiding this comment.
Do you want to allow empty Kind and Plural? Plural could be derived from the CustomResource name, but Kind?
There was a problem hiding this comment.
Do you want to allow empty Kind and Plural? Plural could be derived from the CustomResource name, but Kind?
This used by status validation too. Status may not have all these field set. If they are set, they must be valid, but if they are not set how to handle that varies with where the field is embedded. See the spec validation above.
Also, no information is derived post-defaulting: #45561
deads2k
force-pushed
the
tpr-10-validation
branch
from
1503e95
to
bcf6c66
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, sttts Assign the PR to them by writing
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
sttts
added
release-note-none
|
its the api-extensions thing again: #45490 approving |
deads2k
added
the
approved
|
Automatic merge from submit-queue |
Add basic validation for customresource definitions.
@adohe if you had review bandwidth, this is a relatively small one.