Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded tmp dir path in kubectl test. #45648

Merged
merged 1 commit into from
May 12, 2017
Merged

Fix hardcoded tmp dir path in kubectl test. #45648

merged 1 commit into from
May 12, 2017

Conversation

karataliu
Copy link
Contributor

What this PR does / why we need it:
Current case uses hardcoded tmp dir path, and it does not delete tmp dir after test run.

Which means 1. The case could not be run by different users (no permission) 2. /tmp dir keeps growing.

Which issue this PR fixes

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @karataliu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 11, 2017
sttts
sttts reviewed May 11, 2017
View reviewed changes
pkg/kubectl/cmd/util/factory_test.go Outdated
dir, err := ioutil.TempDir("", "schemaCache")
if err != nil {
t.Errorf("Error getting tempDir: %v", err)
t.FailNow()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.Fatalf does both, doesn't it?

@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 11, 2017
@sttts
Copy link
Contributor

sttts commented May 11, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2017
@sttts
Copy link
Contributor

sttts commented May 11, 2017

One comment, otherwise looks good. Ping me when it's updated.

@karataliu
Copy link
Contributor Author

@sttts Thanks for the review. Updated according to comment.

@sttts
Copy link
Contributor

sttts commented May 12, 2017

@k8s-bot kops aws e2e test this

@sttts
Copy link
Contributor

sttts commented May 12, 2017

Please squash both commits. Looks good now!

@sttts
Copy link
Contributor

sttts commented May 12, 2017

@deads2k approved?

@karataliu
Copy link
Contributor Author

Squashed commit pushed. Thanks

@sttts
Copy link
Contributor

sttts commented May 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2017
@deads2k
Copy link
Contributor

deads2k commented May 12, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, karataliu, sttts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b4b5bfd into kubernetes:master May 12, 2017
@karataliu karataliu deleted the fixtmpdir branch May 15, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

Assignees

@soltysh soltysh

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@karataliu @k8s-reviewable @k8s-ci-robot @sttts @deads2k @k8s-github-robot @soltysh