Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump l7-lb-controller resource usage threshold in tests #45672

Merged
merged 1 commit into from
May 11, 2017
Merged

Bump l7-lb-controller resource usage threshold in tests #45672

merged 1 commit into from
May 11, 2017

Conversation

wojtek-t
Copy link
Member

Fix #45512

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. retest-not-required labels May 11, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2017
@shyamjvs
Copy link
Member

Any reason why 75 and not 65 (which I guess should also be fine)?

@wojtek-t
Copy link
Member Author

I don't want to be that close to the real value (we're observing more than 63MB, so we can also observe more than 65MB).

@shyamjvs
Copy link
Member

/lgtm

Just thought that tight bounds help keep us under better check over time :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

@k8s-bot bazel test this

This was referenced May 11, 2017
Closed
Merged
@wojtek-t
Copy link
Member Author

@k8s-bot bazel test this

@shyamjvs
Copy link
Member

I guess the bazel test should pass once kubernetes/test-infra#2727 is merged. It is an issue with git index locking, and retrying here might not help.

@shyamjvs
Copy link
Member

@k8s-bot bazel test this
Let's see if it works now.

@shyamjvs
Copy link
Member

Yup, it worked.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c93c50b into kubernetes:master May 11, 2017
@wojtek-t wojtek-t deleted the bump_l7_threshold branch May 23, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wojtek-t @shyamjvs @k8s-github-robot @gmarek @k8s-ci-robot