Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #44781 #45680

Merged
merged 1 commit into from
May 15, 2017
Merged

Automated cherry pick of #44781 #45680

merged 1 commit into from
May 15, 2017

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented May 11, 2017

Cherry pick of #44781 on release-1.6.

#44781: Ensure desired state of world populator runs before volume

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 11, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @wongma7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 11, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2017
@wongma7 wongma7 mentioned this pull request May 11, 2017
Merged
@jingxu97 jingxu97 added this to the v1.6 milestone May 11, 2017
@jingxu97 jingxu97 added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-label-needed labels May 11, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 11, 2017
@jingxu97 jingxu97 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 11, 2017
@feiskyer
Copy link
Member

@k8s-bot ok to test

@dims
Copy link
Member

dims commented May 12, 2017

/unassign @dims

@wongma7 wongma7 force-pushed the automated-cherry-pick-of-#44781-upstream-release-1.6 branch from 951baa4 to 7e2ecae Compare May 12, 2017 14:59
@wongma7
Copy link
Contributor Author

wongma7 commented May 12, 2017

@k8s-bot verify test this

@wongma7
Copy link
Contributor Author

wongma7 commented May 12, 2017

@k8s-bot verify test this

#44232

@wongma7
Copy link
Contributor Author

wongma7 commented May 12, 2017

@k8s-bot verify test this

@enisoc
Copy link
Member

enisoc commented May 13, 2017

@k8s-bot verify test this

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enisoc, wongma7
We suggest the following additional approver: saad-ali

Assign the PR to them by writing /assign @saad-ali in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor Author

wongma7 commented May 13, 2017

/assign @saad-ali

@wongma7
Copy link
Contributor Author

wongma7 commented May 15, 2017

@k8s-bot gce etcd3 e2e test this
#43520

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6f3afee into kubernetes:release-1.6 May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feiskyer feiskyer

@enisoc enisoc

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wongma7 @k8s-ci-robot @k8s-github-robot @feiskyer @dims @enisoc @saad-ali @jingxu97