-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print pod startup latency metric as perfdata #45719
Print pod startup latency metric as perfdata #45719
Conversation
test/e2e/framework/perf_util.go
Outdated
}, | ||
Unit: "ms", | ||
Labels: map[string]string{ | ||
"Verb": "POD_STARTUP", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this. I don't think this should be Verb, this should be operation or sth like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to "Metric" now. Hope that works.
test/e2e/framework/perf_util.go
Outdated
Unit: "ms", | ||
Labels: map[string]string{ | ||
"Verb": "POD_STARTUP", | ||
"Resource": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it. Had it just for legacy (following from that of api calls).
5159802
to
1efcf00
Compare
1efcf00
to
48688fa
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmarek, shyamjvs
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 45653, 45719, 45729, 45730, 44250) |
Follows #45657
This should print pod startup latency in same format as api calls latencies.
cc @wojtek-t @gmarek