Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubemark.sh as we don't use pod IP from it anymore #45730

Merged
merged 1 commit into from
May 12, 2017

Conversation

shyamjvs
Copy link
Member

This has been pending for sometime now. We no longer seem to actually depend on the downwarp api for the pod IP (hollow-proxy for example now gets it using api call).

cc @wojtek-t @gmarek

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 12, 2017
@wojtek-t
Copy link
Member

@shyamjvs - please start applying "release-note-note" label.

@shyamjvs shyamjvs added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 12, 2017
@shyamjvs
Copy link
Member Author

Been doing it for sometime now :) (#45720, #45719, #45622, #45604, #45586)

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45653, 45719, 45729, 45730, 44250)

@k8s-github-robot k8s-github-robot merged commit cb9074c into kubernetes:master May 12, 2017
@shyamjvs shyamjvs deleted the remove-kubemark-sh branch May 20, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants