Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop vendoring heapster v1alpha1 #45758

Merged
merged 3 commits into from
May 16, 2017
Merged

Stop vendoring heapster v1alpha1 #45758

merged 3 commits into from
May 16, 2017

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented May 13, 2017 •
edited

Changes to use the one in staging/metrics.

TODO: remove the exception in #45176

Implementing #45498 (comment).

@caesarxuchao caesarxuchao self-assigned this May 13, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 13, 2017
@caesarxuchao
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 13, 2017
@caesarxuchao caesarxuchao force-pushed the remove-vendor-heapster-v1alpha1 branch from 6d9d443 to 9fbf4e7 Compare May 13, 2017 00:48
@caesarxuchao caesarxuchao mentioned this pull request May 13, 2017
Merged
@caesarxuchao caesarxuchao force-pushed the remove-vendor-heapster-v1alpha1 branch from 9fbf4e7 to 1130989 Compare May 15, 2017 16:33
@caesarxuchao caesarxuchao changed the title [WIP] remove vendor heapster v1alpha1 Stop vendoring heapster v1alpha1 May 15, 2017
@caesarxuchao
Copy link
Member Author

@piosz @DirectXMan12 ptal. Thanks!

@caesarxuchao caesarxuchao force-pushed the remove-vendor-heapster-v1alpha1 branch from 1130989 to 1d97347 Compare May 15, 2017 17:54
@DirectXMan12
Copy link
Contributor

LGTM assuming tests pass

@caesarxuchao
Copy link
Member Author

Thanks. All tests passed. Adding lgtm per @DirectXMan12 's comment.

@caesarxuchao
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@caesarxuchao: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@caesarxuchao
Copy link
Member Author

@wojtek-t could you help approve the change? Thanks.

@wojtek-t
Copy link
Member

@caesarxuchao - please squash commits a bit (I would suggest merging 1st and 4th and separately 2nd and 3rd - those two seem to be auto-generated).

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2017
@caesarxuchao caesarxuchao force-pushed the remove-vendor-heapster-v1alpha1 branch from 1d97347 to 27e2129 Compare May 15, 2017 20:07
@caesarxuchao
Copy link
Member Author

@wojtek-t squashed as suggested. Thanks.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2017
rely on staging/metrics instead of on
d9c2fbb 
vendor/k8s.io/heapster/metrics/apis/metrics/v1alpha1

fix some related imports
@caesarxuchao caesarxuchao force-pushed the remove-vendor-heapster-v1alpha1 branch from 27e2129 to 36e2d0b Compare May 15, 2017 20:51
@caesarxuchao
Copy link
Member Author

Rebased.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2017
@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 15, 2017 •
edited

@caesarxuchao: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 36e2d0b link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44337, 45775, 45832, 45574, 45758)

@k8s-github-robot k8s-github-robot merged commit 24cb1ce into kubernetes:master May 16, 2017
@caesarxuchao caesarxuchao mentioned this pull request May 16, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 2, 2017
Merge pull request #45865 from caesarxuchao/remove-exception
dcf19e8 
Automatic merge from submit-queue

remove exception in verify-no-vendor-cycles.sh

The exception is fixed by #45758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DirectXMan12 DirectXMan12

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@caesarxuchao @DirectXMan12 @k8s-ci-robot @wojtek-t @k8s-github-robot @piosz