Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal audit API #45862

Merged
merged 3 commits into from
May 16, 2017
Merged

Conversation

timstclair
Copy link

Forked from #45315

I pulled out only the internal audit API types and would like to merge this to unblock the audit implementation work while we figure out the versioned types and code generation.

I will continue to iterate on #45315, but lets get this internal type submitted.

/cc @ericchiang @ihmccreery

@timstclair timstclair added kind/new-api release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2017
@timstclair timstclair added this to the v1.7 milestone May 16, 2017
@timstclair timstclair requested review from soltysh and sttts May 16, 2017 00:05
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2017
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2017
@timstclair
Copy link
Author

/cc @cheftako

@sttts
Copy link
Contributor

sttts commented May 16, 2017

/lgtm
/approved

We can iterate on this with follow-up PRs. Moreover, this is only the internal type which is not exposed externally.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts, timstclair
We suggest the following additional approver: deads2k

Assign the PR to them by writing /assign @deads2k in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented May 16, 2017

Manually approving because only hack/.linted_packages is changed outside of k8s.io/apiserver.

@sttts sttts added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a4c4cfe into kubernetes:master May 16, 2017
k8s-github-robot pushed a commit that referenced this pull request May 17, 2017
Automatic merge from submit-queue (batch tested with PRs 45884, 45879, 45912, 45444, 45874)

Fix docs for advanced audit

This change updates docs from this pr: #45862

**Release note**:

```
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants