Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MrHohn to couple e2e tests #45898

Merged
merged 1 commit into from
May 17, 2017
Merged

Add MrHohn to couple e2e tests #45898

merged 1 commit into from
May 17, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented May 16, 2017

/assign @bowei

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 16, 2017
bowei
bowei approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowei
Copy link
Member

bowei commented May 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2017
@MrHohn
Copy link
Member Author

MrHohn commented May 16, 2017

/assign @fejta
For approval :)

@fejta
Copy link
Contributor

fejta commented May 16, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, bowei, fejta

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2017
@MrHohn
Copy link
Member Author

MrHohn commented May 16, 2017

@fejta Thanks!

@k8s-ci-robot k8s-ci-robot requested review from fejta and cjwagner and removed request for fejta and cjwagner May 17, 2017 01:56
@k8s-github-robot
Copy link

k8s-github-robot commented May 17, 2017 •
edited by fejta

Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899)

@k8s-github-robot k8s-github-robot merged commit 2d30afb into kubernetes:master May 17, 2017
@MrHohn MrHohn deleted the update-test-owner branch October 5, 2017 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees

@bowei bowei

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrHohn @bowei @fejta @k8s-github-robot @k8s-ci-robot