Fix node e2e panic when not using image config file. #45901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Random-Liu
added
the
release-note-none
k8s-github-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vishh
added
the
priority/critical-urgent
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, vishh
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 44520, 45253, 45838, 44685, 45901) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45430,
resourcesfield in image config is a pointer, and we only initialize it when using image config file.However, we still have test specifying images directly without image config file, this will cause those test to panic. See:
This PR fixes this.
@vishh @mtaufen @kewu1992