-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all API related annotations into annotation_key_constants.go #45926
Move all API related annotations into annotation_key_constants.go #45926
Conversation
/lgtm |
6c10ec8
to
a240a34
Compare
@caesarxuchao Sorry, the failure is hack/.linted_packages. The stale entry (pkg/api/annotations) is removed now. |
a240a34
to
5992425
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better, but I'm still not satisfied :)
// access only from the CIDRs currently allocated to MIT & the USPS. | ||
// | ||
// Not all cloud providers support this annotation, though AWS & GCE do. | ||
AnnotationLoadBalancerSourceRangesKey = "service.beta.kubernetes.io/load-balancer-source-ranges" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're going to extract kubectlPrefix
why not serviceBetaPrefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yeah we could do that later :)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, caesarxuchao, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@MrHohn: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue |
Separate from #45869. See #45869 (comment) for details.
This PR does nothing but move constants around :)
/assign @caesarxuchao
Release note: