Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore kube-proxy --version #46122

Merged
merged 1 commit into from
May 20, 2017
Merged

Restore kube-proxy --version #46122

merged 1 commit into from
May 20, 2017

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented May 19, 2017

Accidentally removed by #34727.

Fixes #46026

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2017
@ncdc
Copy link
Member Author

ncdc commented May 19, 2017

@fasaxc @dcbw @qiujian16 @cmluciano PTAL

cc @sttts @mikedanese @deads2k

@ncdc ncdc mentioned this pull request May 19, 2017
Closed
@ncdc ncdc added the release-note-none Denotes a PR that doesn't merit a release note. label May 19, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2017
@ncdc ncdc force-pushed the kube-proxy-version-flag branch from 22c4847 to f51c2c4 Compare May 19, 2017 18:40
cmluciano
cmluciano reviewed May 19, 2017
View reviewed changes
Copy link

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally too

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2017
@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, mikedanese, ncdc

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46033, 46122, 46053, 46018, 45981)

@k8s-github-robot k8s-github-robot merged commit 078d820 into kubernetes:master May 20, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 20, 2017 •
edited

@ncdc: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Kubemark GCE e2e f51c2c4 link @k8s-bot kubemark e2e test this
pull-kubernetes-federation-e2e-gce f51c2c4 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc ncdc deleted the kube-proxy-version-flag branch October 22, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

Assignees

@cblecker cblecker

@mikedanese mikedanese

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ncdc @cblecker @mikedanese @k8s-github-robot @k8s-ci-robot @cmluciano @dchen1107