Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientgo/examples/in-cluster: add instructions to run the example #46133

Merged

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented May 19, 2017

This patch adds instructions for how to run the in-cluster client-go example.
To make this example executable, providing a Dockerfile and build steps so
that it can directly be run on minikube.

This is part of the body of work improving the client library samples.

Signed-off-by: Ahmet Alp Balkan ahmetb@google.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels May 19, 2017
@ahmetb
Copy link
Member Author

ahmetb commented May 19, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 19, 2017
This patch adds instructions for how to run the in-cluster client-go example.
To make this example executable, providing a Dockerfile and build steps so
that it can directly be run on minikube.

This is part of the body of work improving the client library samples.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb force-pushed the clientgo-examples/in-cluster branch from f45cd9b to 8604ed6 Compare May 19, 2017 21:55
@ahmetb
Copy link
Member Author

ahmetb commented May 19, 2017

that was likely a flake:
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@ahmetb
Copy link
Member Author

ahmetb commented May 20, 2017

more flake.
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@sttts
Copy link
Contributor

sttts commented May 22, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@sttts
Copy link
Contributor

sttts commented May 22, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, sttts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2017
@yujuhong yujuhong removed their assignment May 22, 2017
@ahmetb
Copy link
Member Author

ahmetb commented May 22, 2017

@k8s-bot kops aws e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@ahmetb
Copy link
Member Author

ahmetb commented May 22, 2017

hmm the test failures do not appear to be related to the patch, but are consistent:

@k8s-bot kops aws e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@ahmetb
Copy link
Member Author

ahmetb commented May 22, 2017

@sttts I think I need help diagnosing why am I keep getting the same set of test failures, which seems like they are not relevant to this patch. I appreciate any tips.

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/46133/pull-kubernetes-federation-e2e-gce/6064/
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/46133/pull-kubernetes-e2e-kops-aws/26160/

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@ahmetb: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 8604ed6 link @k8s-bot pull-kubernetes-federation-e2e-gce test this
pull-kubernetes-e2e-gce-etcd3 8604ed6 link @k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46133, 46211, 46224, 46205, 45910)

@k8s-github-robot k8s-github-robot merged commit 2cb0cda into kubernetes:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants