Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to dump kubemark master logs #46164

Merged
merged 1 commit into from
May 22, 2017

Conversation

shyamjvs
Copy link
Member

First step towards solving the issue #46109.

cc @kubernetes/test-infra-maintainers @wojtek-t @gmarek

@shyamjvs shyamjvs added the release-note-none Denotes a PR that doesn't merit a release note. label May 20, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2017
@shyamjvs
Copy link
Member Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@shyamjvs
Copy link
Member Author

@k8s-bot kops aws e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@shyamjvs
Copy link
Member Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

1 similar comment
@shyamjvs
Copy link
Member Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@wojtek-t
Copy link
Member

I don't understand the idea behind this script.
Basically, in successful runs, we are somehow gathering all logs from everything we need. Instead of introducing another script, we should ensure that the logic that is running in successful runs is called also in the timed out ones.
@ixdy - I think you worked on it at some point. Feel free to redirect it to someone else.

@shyamjvs
Copy link
Member Author

@wojtek-t Currently the logs for kubemark (similar to real cluster) are collected as part of ginkgo after it finishes running the test suite (see: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/e2e.go#L265). So the logs are 'only' collected after running the e2e tests. Thus if test fails during cluster startup step, we don't get the logs. To counter this problem in the case of real cluster tests, we call DumpClusterLogs in case Up failed (see: https://github.com/kubernetes/test-infra/blob/master/kubetest/e2e.go#L100). I'm replicating the same logic for kubemark too (by PR kubernetes/test-infra#2813). And this script is kind of a wrapper around cluster/log-dump.sh to make it run on the kubemark master (otherwise it'd run on the real master).

@wojtek-t
Copy link
Member

OK - this is calling the alerady existing "log-dump.sh" script, I think I missed this initially.
Yeah - that sounds reasonable to me.

@shyamjvs
Copy link
Member Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

# limitations under the License.

export KUBERNETES_PROVIDER="kubemark"
export KUBE_CONFIG_FILE="config-default.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be hardcoded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Otherwise it doesn't work. I guess it's because log-dump.sh sets this to config-test.sh (https://github.com/kubernetes/kubernetes/blob/master/cluster/log-dump.sh#L61)

@wojtek-t
Copy link
Member

OK - let's see if it will work.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@shyamjvs
Copy link
Member Author

@k8s-bot unit test this

@shyamjvs
Copy link
Member Author

@k8s-bot gce etcd3 e2e test this
@k8s-bot kops aws e2e test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2017

@shyamjvs: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 360054a link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b00c1b6 into kubernetes:master May 22, 2017
@shyamjvs shyamjvs deleted the master-log-kubemark branch May 22, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants