-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to dump kubemark master logs #46164
Add script to dump kubemark master logs #46164
Conversation
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
1 similar comment
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
I don't understand the idea behind this script. |
@wojtek-t Currently the logs for kubemark (similar to real cluster) are collected as part of ginkgo after it finishes running the test suite (see: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/e2e.go#L265). So the logs are 'only' collected after running the e2e tests. Thus if test fails during cluster startup step, we don't get the logs. To counter this problem in the case of real cluster tests, we call DumpClusterLogs in case Up failed (see: https://github.com/kubernetes/test-infra/blob/master/kubetest/e2e.go#L100). I'm replicating the same logic for kubemark too (by PR kubernetes/test-infra#2813). And this script is kind of a wrapper around |
OK - this is calling the alerady existing "log-dump.sh" script, I think I missed this initially. |
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
# limitations under the License. | ||
|
||
export KUBERNETES_PROVIDER="kubemark" | ||
export KUBE_CONFIG_FILE="config-default.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Otherwise it doesn't work. I guess it's because log-dump.sh sets this to config-test.sh (https://github.com/kubernetes/kubernetes/blob/master/cluster/log-dump.sh#L61)
OK - let's see if it will work. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shyamjvs, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot unit test this |
@shyamjvs: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue |
First step towards solving the issue #46109.
cc @kubernetes/test-infra-maintainers @wojtek-t @gmarek