Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support validating package versions in node conformance test #46238

Merged
merged 2 commits into from
Jun 2, 2017
Merged

Support validating package versions in node conformance test #46238

merged 2 commits into from
Jun 2, 2017

Conversation

yguo0905
Copy link
Contributor

@yguo0905 yguo0905 commented May 22, 2017 •
edited

ref: #46891

What this PR does / why we need it:

This PR adds a package validator in node conformance test for checking whether the locally installed packages meet the image spec.

Special notes for your reviewer:

The image spec for GKE (which has the package spec) will be in a separate PR. Then we will publish a new node conformance test image for GKE whose name should use the convention in #45760 and have gke in it.

Release note:

NONE

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2017
@yguo0905
Copy link
Contributor Author

@dchen1107

@dchen1107 dchen1107 assigned dchen1107 and unassigned dims and thockin May 22, 2017
@yguo0905 yguo0905 force-pushed the package-validator branch 3 times, most recently from 0eaa127 to d3dd9c6 Compare May 26, 2017 18:45
@dchen1107
Copy link
Member

Can we switch the existing node conformance test to use this new package validator? A separate pr should be ok.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2017
@dchen1107
Copy link
Member

@k8s-bot pull-kubernetes-unit test this

@dchen1107
Copy link
Member

@k8s-bot pull-kubernetes-verify test this

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@yguo0905
Copy link
Contributor Author

@k8s-bot pull-kubernetes-unit test this

@yguo0905
Copy link
Contributor Author

@dchen1107, the test failed because of a godep issue on updating the semver version. I've fixed it in the "Update semver to 3.5.0" commit -- the "Support validating package versions in node conformance test" commit is unchanged. PTAL.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yguo0905

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yguo0905
Copy link
Contributor Author

yguo0905 commented Jun 1, 2017

@k8s-bot pull-kubernetes-unit test this
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@yguo0905
Copy link
Contributor Author

yguo0905 commented Jun 2, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-verify test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46648, 46500, 46238, 46668, 46557)

@k8s-github-robot k8s-github-robot merged commit a6f0033 into kubernetes:master Jun 2, 2017
@yguo0905 yguo0905 mentioned this pull request Jun 2, 2017
Closed
4 tasks
@yguo0905 yguo0905 deleted the package-validator branch July 28, 2017 17:10
@yguo0905 yguo0905 mentioned this pull request Jul 28, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 29, 2017
Merge pull request #49807 from yguo0905/automated-cherry-pick-of-#462…
d78ab89 
…38-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #46238

Cherry pick of #46238 on release-1.6.

#46238: Support validating package versions in node conformance test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yguo0905 @dchen1107 @k8s-github-robot @dims @calebamiles @thockin @k8s-ci-robot