Summary Test looks at pods that have containers that restart. #46308
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/M
|
/release-note-none |
k8s-ci-robot
added
release-note-none
dashpole
force-pushed
the
summary_container_restart
branch
from
0c0888f
to
1a6572f
Compare
|
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
|
@dashpole: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dchen1107 this looks like it is ready for review. The federation test doesnt seem to pass for whatever reason |
| createSummaryTestPods(f, pod0, pod1) | ||
| // Wait for cAdvisor to collect 2 stats points | ||
| time.Sleep(15 * time.Second) | ||
| pods := getSummaryTestPods(f, pod0, pod1) |
There was a problem hiding this comment.
Can you point to me where we ensure there is no duplicate stats for a single container within your test pod?
There was a problem hiding this comment.
To match the containers in a pod, we use the MatchAllElements method of gstruct. This matches elements in a list, with one match allowed for each. See the tests for gstruct. So we were already checking for duplicate elements before. We just never tested on a restarted container.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dchen1107
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 46429, 46308, 46395, 45867, 45492) |
|
@dashpole @dchen1107 This broke cross-build. cc @luxas |
|
@gmarek can you show me a failure? What broke it? |
|
finally managed to run make cross |
Automatic merge from submit-queue Fix Cross-Build, and reduce test to 1 restart to reduce flakyness In response to #46308 (comment) This fixes the error: `test/e2e_node/summary_test.go:138: constant 100000000000 overflows int` from the cross build. This [recent flake](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet/4179) was because the container restarted during the period where the test expected to Continually see the container in the Summary API. /assign @dchen1107 cc @gmarek @luxas /release-note-none
Occasionally, the node can report extra containers that had been restarted through the summary API.
This test change tests a pod that restarts, and hopefully should allow us to reproduce and debug this behavior.
/assign @dchen1107
/release-note-none