Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'flexvolume' prefix to FlexVolume plugin names. #46382

Merged
merged 1 commit into from Jun 17, 2017
Merged

Adding 'flexvolume' prefix to FlexVolume plugin names. #46382

merged 1 commit into from Jun 17, 2017

Conversation

verult
Copy link
Contributor

@verult verult commented May 24, 2017 •
edited

What this PR does / why we need it: Adds a prefix to FlexVolume plugin names in order to more easily identify plugins as FlexVolume. Improves debugging.

Special notes for your reviewer: Unfortunately the delimiter after 'flexvolume' is restricted to either '-' or '.' . This makes the prefix seem like it's part of the vendor name. Not sure if this could cause issues later on.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @verult. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2017
@verult
Copy link
Contributor Author

verult commented May 24, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2017
@chakri-nelluri
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@chakri-nelluri: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2017
@verult
Copy link
Contributor Author

verult commented May 30, 2017

/assign @msau42

@msau42
Copy link
Member

msau42 commented May 30, 2017

@k8s-bot ok to test

@msau42
Copy link
Member

msau42 commented May 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017
@msau42
Copy link
Member

msau42 commented Jun 1, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2017
@msau42
Copy link
Member

msau42 commented Jun 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@jingxu97 jingxu97 added this to the v1.7 milestone Jun 2, 2017
liggitt
liggitt reviewed Jun 2, 2017
View reviewed changes
pkg/volume/flexvolume/plugin.go
@@ -62,7 +62,7 @@ func (plugin *flexVolumePlugin) getExecutable() string {

// Name is part of the volume.VolumePlugin interface.
func (plugin *flexVolumePlugin) GetPluginName() string {
return plugin.driverName
return "flexvolume-" + plugin.driverName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal, but I would have expected flexvolume.kubernetes.io/...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there'd be an issue with two '/' s, since vendor and driver are separated by a slash in driverName as well. /cc @chakri-nelluri

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 6, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2017
@marun marun added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 8, 2017
@verult
Copy link
Contributor Author

verult commented Jun 13, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/assign
lgtm'ing based on above comments

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chakri-nelluri, msau42, spiffxp, verult, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38751, 44282, 46382, 47603, 47606)

@k8s-github-robot k8s-github-robot merged commit fdc6746 into kubernetes:master Jun 17, 2017
@verult verult deleted the FlexVolumeMinorPatches branch March 24, 2018 01:13
@chakri-nelluri chakri-nelluri mentioned this pull request Dec 17, 2018
Closed
@gaorong gaorong mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@chakri-nelluri chakri-nelluri chakri-nelluri approved these changes

Assignees

@spiffxp spiffxp

@ivan4th ivan4th

@deads2k deads2k

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet