Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment error in function newVolumeMounterFromPlugins #46587

Merged
merged 1 commit into from Jun 1, 2017
Merged

fix comment error in function newVolumeMounterFromPlugins #46587

merged 1 commit into from Jun 1, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented May 29, 2017

What this PR does / why we need it:

Fix the comment error in function newVolumeMounterFromPlugins, which may cause confusion.

@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 29, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 29, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2017
@gyliu513
Copy link
Contributor

@k8s-bot ok to test

@gyliu513
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 29, 2017
@dixudx
Copy link
Member Author

dixudx commented May 29, 2017

/assign @timstclair

pmorie
pmorie reviewed May 30, 2017
View reviewed changes
pkg/kubelet/kubelet_volumes.go Outdated
@@ -78,7 +78,7 @@ func (kl *Kubelet) newVolumeMounterFromPlugins(spec *volume.Spec, pod *v1.Pod, o
}

// cleanupOrphanedPodDirs removes the volumes of pods that should not be
// running and that have no containers running. Note that we roll up logs here since it runs in the main loop.
// running and that have no containers running. Note that we roll up logs here since it runs in the main loop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your wrap this line at 80 chars? LGTM otherwise.

@pmorie
Copy link
Member

pmorie commented May 30, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2017
@dixudx
Copy link
Member Author

dixudx commented May 31, 2017 •
edited

@pmorie Needs your approval. Thanks.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2017
@dixudx dixudx force-pushed the fix_comment_in_newVolumeMounterFromPlugins branch from d7997fc to ae4f9c8 Compare June 1, 2017 04:48
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2017
@dixudx
Copy link
Member Author

dixudx commented Jun 1, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

1 similar comment
@dixudx
Copy link
Member Author

dixudx commented Jun 1, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@timstclair
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, timstclair

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 68dd748 into kubernetes:master Jun 1, 2017
@dixudx dixudx deleted the fix_comment_in_newVolumeMounterFromPlugins branch September 9, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmorie pmorie pmorie left review comments

Assignees

@pmorie pmorie

@timstclair timstclair

@tmrts tmrts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dixudx @k8s-ci-robot @gyliu513 @pmorie @timstclair @k8s-github-robot @tmrts