-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #45250 #46653
Automated cherry pick of #45250 #46653
Conversation
The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks) |
/assign @mikedanese @spxtr This makes test-infra configs easier (just use |
/lgtm |
This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
curtis.l.bates@gmail.com
Domain imwiz.com has exceeded the max emails per hour (178/150 (118%)) allowed. Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
------ The body of the message is 5394 characters long; only the first
------ 5000 or so are included here.
Received: from o7.sgmail.github.com ([167.89.101.198]:5118)
by box969.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.87)
(envelope-from <bounces+848413-5c7e-dev=imwiz.com@sgmail.github.com>)
id 1dGTP2-000Wok-6A
for dev@imwiz.com; Thu, 01 Jun 2017 10:56:52 -0600
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=4eW7VofmYFgC7SLazd/d7sUw4fo=; b=nofsWpMJj8QDUG3u
CsGNui3n3vT3S4W0gIgWQSQ4J3X30h6u2Le5eho5HBw/oymHT4TGH2u8wDyjazJd
6eLC9I8Kt0VbAWFJkZLZE4UcR46UFu1vOa9lTJq4hy1vpx4TxWoo+F/UvwVnDM5f
8wVMAxZxPiIY1uypVbawebhvdk0=
Received: by filter0910p1mdw1.sendgrid.net with SMTP id filter0910p1mdw1-20344-59304749-C
2017-06-01 16:56:41.075379718 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17])
by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id CYReRtXmR2GZqPZYpnWaeA
for <dev@imwiz.com>; Thu, 01 Jun 2017 16:56:41.038 +0000 (UTC)
Date: Thu, 01 Jun 2017 09:56:40 -0700
From: Kubernetes Submit Queue <notifications@github.com>
Reply-To: kubernetes/kubernetes <reply@reply.github.com>
To: kubernetes/kubernetes <kubernetes@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <kubernetes/kubernetes/pull/46653/c305555030@github.com>
In-Reply-To: <kubernetes/kubernetes/pull/46653@github.com>
References: <kubernetes/kubernetes/pull/46653@github.com>
Subject: Re: [kubernetes/kubernetes] Automated cherry pick of #45250 (#46653)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_59304748e06ed_53df3f8f63bcfc3c3213a";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: k8s-merge-robot
X-GitHub-Recipient: falenn
X-GitHub-Reason: subscribed
List-ID: kubernetes/kubernetes <kubernetes.kubernetes.github.com>
List-Archive: https://github.com/kubernetes/kubernetes
List-Post: <mailto:reply@reply.github.com>
List-Unsubscribe: <mailto:unsub+000ab60abba20e450c5c94639b74bd5f6fe388a9dd02fb2492cf000000011548094892a169ce0dda40c6@reply.github.com>,
<https://github.com/notifications/unsubscribe/AAq2CocQfTPM5XOh8Y-bR-qjvc_inwTNks5r_u1IgaJpZM4Nq9Rg>
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: dev@imwiz.com
X-SG-EID: APO41b8ovafPb3SK9rw3vGnjYNcR7WXxsm8J+BVesM5eJvm1lcxbOM+dnNh48xuop4I2zKfe+pCcK1
JzMPRVfr5Q5S9wXWrjRrfUDeISkE5VFY550FxrlA0En/R9m9lHiwLyP6TA8UdhIvIsQkiC0HbLLfYv
jt526itIARQ5U0bY+744tWS+C3yonMLqxjq0tVtm61UWjKiDwozznPUuwcUgMiq44ByeSrzN22/Cn/
4=
X-Spam-Status: No, score=-1.7
X-Spam-Score: -16
X-Spam-Bar: -
X-Ham-Report: Spam detection software, running on the system "box969.bluehost.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
root\@localhost for details.
Content preview: [APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request
has been approved by: *<a href="#46653#"
title="Author self-approved">ixdy</a>*, *<a href="#46653 (comment)"
title="LGTM">spxtr</a>* We suggest the following additional approver: **dchen1107**
[...]
Content analysis details: (-1.7 points, 4.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[167.89.101.198 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-1.6 AWL AWL: Adjusted score from AWL reputation of From: address
X-Spam-Flag: NO
----==_mimepart_59304748e06ed_53df3f8f63bcfc3c3213a
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
[APPROVALNOTIFIER] This PR is **NOT APPROVED**
This pull-request has been approved by: *<a href="#46653#" title="Author self-approved">ixdy</a>*, *<a href="#46653 (comment)" title="LGTM">spxtr</a>*
We suggest the following additional approver: **dchen1107**
Assign the PR to them by writing `/assign @dchen1107` in a comment when ready.
The full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
<details open>
Needs approval from an approver in each of these OWNERS Files:
- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**
You can indicate your approval by writing `/approve` in a comment
You can cancel your approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["dchen1107"]} -->
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#46653 (comment)
----==_mimepart_59304748e06ed_53df3f8f63bcfc3c3213a
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p>[APPROVALNOTIFIER] This PR is <strong>NOT APPROVED</strong></p>
<p>This pull-request has been approved by: <em><a href=3D"https://github.co=
m/kubernetes/kubernetes/pull/46653#">ixdy</a></em>, <em><a href=3D"https://=
github.com/kubernetes/kubernetes/pull/46653#issuecomment-305554757">spxtr</=
a></em><br>
We suggest the following additional approver: <strong>dchen1107</strong></p>
<p>Assign the PR to them by writing <code>/assign @dchen1107</code> in a co=
mment when ready.</p>
<p>The full list of commands accepted by this bot can be found <a href=3D"h=
ttps://github.com/kubernetes/test-infra/blob/master/commands.md">here</a>.<=
/p>
<details open=3D"">
Needs approval from an approver in each of these OWNERS Files:
<ul>
<li><strong><a href=3D"https://github.com/kubernetes/kubernetes/blob/master=
/OWNERS">OWNERS</a></strong></li>
</ul>
<p>You can indicate your approval by writing <code>/approve</code> in a com=
ment<br>
You can cancel your approval by writing <code>/approve cancel</code> in a c=
omment</p>
</details>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, <a href=3D"https://github.com/kubernetes=
/kubernetes/pull/46653#issuecomment-305555030">view it on GitHub</a>, or <a=
href=3D"https://github.com/notifications/unsubscribe-auth/AAq2CpeOLH1QLBaS=
FmFeXPrQCLX5RDX-ks5r_u1IgaJpZM4Nq9Rg">mute the thread</a>.<img alt=3D"" hei=
ght=3D"1" src=3D"https://github.com/notifications/beacon/AAq2Crd3dsXgzG9wbV=
nf5CD5fSbzq6o5ks5r_u1IgaJpZM4Nq9Rg.gif" width=3D"1" /></p>
<div itemscope itemtype=3D"http://schema.org/EmailMessage">
<div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewAction=
">
<link itemprop=3D"url" href=3D"https://github.com/kubernetes/kubernetes/p=
ull/46653#issuecomment-305555030"></link>
<meta itemprop=3D"name" content=3D"View Pull Request"></meta>
</div>
<meta itemprop=3D"description" content=3D"View this Pull Request on GitHub"=
</meta>
</div>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_version"=
:"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"Gi=
tHub"},"entity":{"external_key":"github/kubernetes/kubernetes","title":"kub=
ernetes/kubernetes","subtitle":"GitHub repository","main_image_url":"https:=
//cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95f=
c-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com=
/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":=
{"name":"Open in GitHub","url":"https://github.com/kubernetes/kubernetes"}}=
,"updates":{"snippets":[{"icon":"PERSON","message":"@k8s-merge-robot in #46=
653: [APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request ha=
s been approved by: *\u003ca href=3D\"https://github.com/kubernetes/kuberne=
tes/pull/46653#\" title=3D\"Author self-approved\"\u003eixdy\u003c/a\u003e*=
, *\u003ca href=3D\"#46653 (comment)=
uecomment-305554757\" title=3D\"LGTM\"\u003espxtr\u003c/a\u003e*\nWe sugges=
t the following additional approver: **dchen1107**\n\nAssign the PR to them=
by writing `/assign @dchen1107` in a comment when ready.\n\nThe full list =
of commands accepted by this bot can be found [here](https://github.com/kub=
ernetes/test-infra/blob/master/commands.md).\n\n\u003cdetails open\u003e\nN=
eeds approval from an approver in each of these OWNERS Files:\n\n- **[OWNER=
S](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n\nYou ca=
n indicate your ap
|
/lgtm |
/assign @thockin |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, mikedanese, spxtr, thockin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
Automatic merge from submit-queue |
Cherry pick of #45250 on release-1.6.
#45250: Rename //:ci-artifacts rule to //:push-build, and add a