-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl config get-contexts: sort output #46946
kubectl config get-contexts: sort output #46946
Conversation
Hi @kellycampbell. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot ok to test |
62c2234
to
a9735ee
Compare
/assign alexandercampbell |
/unassign |
/assign |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
673a55d
to
9f74685
Compare
/test pull-kubernetes-bazel |
/retest |
/test pull-kubernetes-bazel |
Seems like a lot of tests are having trouble recently. I pulled your branch locally to see if there was an issue with an out-of-date bazel file but everything seemed to be updated correctly. Hopefully retesting one more time fixes the issue. |
Thanks. I was only able to test the local bazel tests, e.g. bazel test
pkg/kubectl:all, as I'm not setup for the e2e tests.
…On Tue, Aug 1, 2017 at 4:43 PM, Alexander Campbell ***@***.*** > wrote:
Seems like a lot of tests are having trouble recently.
I pulled your branch locally to see if there was an issue with an
out-of-date bazel file but everything seemed to be updated correctly.
Hopefully retesting one more time fixes the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46946 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAmNTvRRCjv_SCEen2dM9Z1c7om9-kzTks5sT44IgaJpZM4Nvg83>
.
|
/retest |
2 similar comments
/retest |
/retest |
/assign @liggitt |
This will be so much better, especially for people building automated scripts using |
cc: @kubernetes/kubectl-maintainers |
This should be in for a while. @pwittrock Can you please approve? |
/test pull-kubernetes-e2e-gce-etcd3 |
Ping @liggitt for approval. |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandercampbell, kellycampbell, liggitt Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
@kellycampbell: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 46946, 45792). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This sorts the output of kubectl config get-contexts because the ordering is otherwise non-stable and makes it harder to find the context you're looking for when you have more than a few.