GC should retry on patch error

[caesarxuchao]

Fixing #46998.

This is fixing a bug, so applying the 1.7 milestone.

[lavalamp]

test? also I think the milestone goes on the issue.

[caesarxuchao]

Added a unit test. @lavalamp PTAL. Thanks.

[caesarxuchao]

/release-note-none

[caesarxuchao]

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

[0xmichalis]

/lgtm

[lavalamp]

It is not clear to me why this change causes a retry--I was hoping the test would demonstrate the retry behavior but I am still confused :)

[0xmichalis]

It is not clear to me why this change causes a retry--I was hoping the test would demonstrate the retry behavior but I am still confused :)

attemptToOrphanWorker adds the item back in the queue if orphanDependents returns an error.

[caesarxuchao]

+1 on what @Kargakis said

Regarding the test, it will be complicated to write a unit test to verify the queue status since we don't have a fake queue, so i just wrote the unit test to verify a proper error is returned by orphanDependents.

[0xmichalis]

Regarding the test, it will be complicated to write a unit test to verify the queue status since we don't have a fake queue, so i just wrote the unit test to verify a proper error is returned by orphanDependents.

FWIW, I wrote a similar test a while back for Recreate deployments: e2695d9 (check TestPodDeletionEnqueuesRecreateDeployment).

[caesarxuchao]

@k8s-bot pull-kubernetes-e2e-kops-aws test this

[lavalamp]

/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, kargakis, lavalamp

Associated issue: 46998

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/controller/OWNERS [lavalamp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[caesarxuchao]

/retest

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 47000, 47188, 47094, 47323, 47124)

[k8s-ci-robot]

@caesarxuchao: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-etcd3	a0a2e95	link	@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.