Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-repo link #47223

Merged
merged 1 commit into from Jun 16, 2017
Merged

Fix cross-repo link #47223

merged 1 commit into from Jun 16, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jun 9, 2017

Fixing #47211

@sttts sttts added kind/bug Categorizes issue or PR as related to a bug. retest-not-required-docs-only labels Jun 9, 2017
@sttts sttts added this to the v1.7 milestone Jun 9, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 9, 2017
@sttts
Copy link
Contributor Author

sttts commented Jun 9, 2017

Not sure there is a better solution. The link must work inside of staging and in the client-go repo. Making in-project+cross-project links seems to be impossible.

@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 9, 2017
@ahmetb
Copy link
Member

ahmetb commented Jun 9, 2017

@sttts still 404 for me: https://github.com/kubernetes/apiextensions-apiserver/ Is this repo private?

@sttts
Copy link
Contributor Author

sttts commented Jun 9, 2017

@ahmetb it doesn't exist yet ;-) Compare by kubernetes-dev mail from yesterday.

cblecker
cblecker requested changes Jun 9, 2017
View reviewed changes
staging/src/k8s.io/client-go/examples/custom-resources/README.md Outdated
@@ -4,4 +4,4 @@

For a client-go example using CustomResourceDefinitions, go to

http://github.com/kubernetes/apiextensions-apiserver/examples/client-go.
[k8s.io/apiextensions-apiserver/examples/client-go](https://github.com/kubernetes/apiextensions-apiserver/tree/master/examples/client-go).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin created https://git.k8s.io for stuff like this.
Try https://git.k8s.io/apiextentions-apiserver/examples/client-go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a dead link right now...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ahmetb
Copy link
Member

ahmetb commented Jun 9, 2017 •
edited

This example probably should not have been merged in the first place if the corresponding repository doesn't exist yet? 😕

@sttts sttts force-pushed the sttts-fix-cr-example-link branch from baf6dee to 2aa87e4 Compare June 12, 2017 07:40
cblecker
cblecker approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except that kubernetes/apiextensions-apiserver is empty. Once there is content here, then this can be merged.

@sttts
Copy link
Contributor Author

sttts commented Jun 12, 2017

Repo exists, but is still empty. @caesarxuchao is updating the bot now.

@marun marun added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 12, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/retest

@ahmetb
Copy link
Member

ahmetb commented Jun 16, 2017

pull-kubernetes-federation-e2e-gce is flaky: #47672

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

OK, there's content here https://github.com/kubernetes/apiextensions-apiserver
Going to lgtm based on @cblecker's review
/assign

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, sttts

Associated issue: 47211

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cblecker cblecker mentioned this pull request Jun 16, 2017
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 532cb25 into kubernetes:master Jun 16, 2017
nikhita
nikhita reviewed Jun 19, 2017
View reviewed changes
staging/src/k8s.io/client-go/examples/custom-resources/README.md
@@ -4,4 +4,4 @@

For a client-go example using CustomResourceDefinitions, go to

http://github.com/kubernetes/apiextensions-apiserver/examples/client-go.
[k8s.io/apiextensions-apiserver/examples/client-go](https://git.k8s.io/apiextentions-apiserver/examples/client-go).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/apiextentions/apiextensions. fix in #47684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@nikhita nikhita nikhita left review comments

@cblecker cblecker cblecker approved these changes

Assignees

@spiffxp spiffxp

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sttts @ahmetb @spiffxp @k8s-github-robot @cblecker @thockin @nikhita @marun @k8s-ci-robot