Removed mesos as cloud provider from Kubernetes. #47232

gyliu513 · 2017-06-09T09:15:02Z

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47205

Special notes for your reviewer:

Release note:

Move Mesos Cloud Provider out of Kubernetes Repo

dims · 2017-06-09T11:16:53Z

@gyliu513 Moving this code to an external cloud provider?

luxas · 2017-06-09T12:16:25Z

Yay, moving these things out-of-monorepo is a great step for the project!
Thanks @gyliu513 for making that possible!

I'd edit this to add a release note though 😄

gyliu513 · 2017-06-09T13:06:37Z

@dims Yes, there are some discussion at at xref #34924 , but I'd like we first move this out of the repo of kubernetes as first step.

gyliu513 · 2017-06-09T13:11:15Z

/release-note

gyliu513 · 2017-06-09T13:11:36Z

@luxas done, thanks ;)

luxas · 2017-06-09T18:14:34Z

@thockin woot, let's get this LGTM'd :)

luxas · 2017-06-09T18:15:43Z

For context to others reading this thread, this is following proposal https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cloud-provider-refactoring.md to make Kubernetes core leaner, one step at a time

k82cn · 2017-06-09T22:30:04Z

sorry for the confusion by (#34924), kube-mesos still need this provider to get all hosts from Mesos until external cloud-provider is done.

luxas · 2017-06-24T08:23:17Z

@k82cn Is there any tracking issue for moving mesos out?

k82cn · 2017-06-25T00:03:44Z

@luxas , #34924 is used to trace moving mesos out; let me update sub-tasks and dependencies.

gyliu513 · 2017-07-05T01:47:12Z

I think the kube-mesos project is dead and I belive no one is working on it, I think that it is time to retire it from Kubernetes. @luxas

luxas · 2017-07-05T09:38:35Z

I think the kube-mesos project is dead and I belive no one is working on it, I think that it is time to retire it from Kubernetes.

SGTM, the incubation project kube-mesos-framework hasn't been updated in ~9 months so...

k82cn · 2017-07-05T11:19:26Z

SGTM, the incubation project kube-mesos-framework hasn't been updated in ~9 months so...

I think China Unicom or Didi maybe using that, and I'm not sure whether Mesosphere will include k8s in its DC/OS . Let me check whether anyone of them would like to invest resource for this project.

luxas · 2017-07-05T13:03:15Z

@k82cn Anyway, that's not blocking this PR, or is it?

k82cn · 2017-07-05T13:13:44Z

@luxas , let me check the status of "pluggable cloud providers" in 1.7; if it's ready, I think we can continue to merge this PR.

k82cn · 2017-07-06T03:44:48Z

@luxas , as we slack yesterday, ccm is enough for kube-mesos; so I think we can merge this PR :).

k82cn · 2017-07-06T03:44:58Z

/lgtm

gyliu513 · 2017-07-10T02:02:24Z

@k82cn did not quite catch what do you mean, can you explain more?

So I need first run godep-restore.sh then godep-save.sh?

But when I run godep-restore.sh, it failed.

root@pc005:~/go/src/k8s.io/kubernetes# ./hack/godep-restore.sh
Starting to download all kubernetes godeps. This takes a while
godep: error downloading dep (vbom.ml/util/sortorder): unrecognized import path "vbom.ml/util/sortorder"
godep: Error downloading some deps. Aborting restore and check.
!!! Error in ./hack/godep-restore.sh:28
  Error in ./hack/godep-restore.sh:28. 'GOPATH=${GOPATH}:${KUBE_ROOT}/staging godep restore "$@"' exited with status 1
Call stack:
  1: ./hack/godep-restore.sh:28 main(...)
Exiting with status 1

k82cn · 2017-07-10T05:08:49Z

Because of GFW ?

sttts · 2017-07-10T06:53:10Z

The deleted files are all bazel BUILD files. Do a hack/update-bazel.sh after godep-save.sh.

gyliu513 · 2017-07-10T07:20:22Z

Thanks @sttts and @k82cn

I think what @sttts proposed does make sense as my VM was located in US and there is no GFW. After I finished both ./hack/godep-save.sh and hack/update-godep-licenses.sh, then when I run hack/update-bazel.sh, it failed again as following, complaining cannot find vendor/github.com/docker/docker/project/CONTRIBUTORS.md as this file was already deleted when I run ./hack/godep-save.sh.

root@pc005:~/go/src/k8s.io/kubernetes# ./hack/update-bazel.sh
F0710 03:14:50.252162   22870 gazel.go:54] err walking vendor: stat vendor/github.com/docker/docker/project/CONTRIBUTORS.md: no such file or directory
goroutine 1 [running]:
gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog.stacks(0xc42052ea00, 0xc4202893b0, 0x97, 0xeb)
	/root/go/src/gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog/glog.go:766 +0xa7
gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog.(*loggingT).output(0x6c05a0, 0xc400000003, 0xc4202e3600, 0x6a2614, 0x8, 0x36, 0x0)
	/root/go/src/gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog/glog.go:717 +0x348
gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog.(*loggingT).printf(0x6c05a0, 0xc400000003, 0x5dd1ff, 0x16, 0xc4200f1f38, 0x1, 0x1)
	/root/go/src/gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog/glog.go:655 +0x14f
gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog.Fatalf(0x5dd1ff, 0x16, 0xc4200f1f38, 0x1, 0x1)
	/root/go/src/gopkg.in/mikedanese/gazel.v17/vendor/github.com/golang/glog/glog.go:1145 +0x67
main.main()
	/root/go/src/gopkg.in/mikedanese/gazel.v17/gazel/gazel.go:54 +0x2cd
!!! Error in ./hack/update-bazel.sh:40
  Error in ./hack/update-bazel.sh:40. '"${gazel}" -root="$(kube::realpath ${KUBE_ROOT})"' exited with status 255
Call stack:
  1: ./hack/update-bazel.sh:40 main(...)
Exiting with status 1

The steps I did was as following:

Step 1: Remove Godeps/ and vendor/, then run ./hack/godep-save.sh

root@pc005:~/go/src/k8s.io/kubernetes# ./hack/godep-save.sh
Don't forget to run hack/update-godep-licenses.sh if you added or removed a dependency!

Step 2: Run hack/update-godep-licenses.sh

root@pc005:~/go/src/k8s.io/kubernetes# hack/update-godep-licenses.sh

Step 3: Run hack/update-bazel.sh failed as above.

@sttts any comments for this? Thanks!

sttts · 2017-07-10T07:35:52Z

Known issue. Solution: delete vendor/github.com/docker/docker/project/

sttts · 2017-07-10T07:44:33Z

@gyliu513 can you test #48685?

gyliu513 · 2017-07-10T08:10:14Z

/retest

luxas · 2017-07-10T08:46:36Z

@gyliu513 I think that worked 🎉
The test failures are unrelated AFAICS

sttts · 2017-07-10T08:51:13Z

Yes, tests are broken #48683 and federation times out or looses connection.

mikedanese · 2017-07-10T08:56:18Z

Love the diff :)

sttts · 2017-07-10T09:11:08Z

Love the -68k lines of code.

k82cn · 2017-07-10T09:13:58Z

+1 :).

gyliu513 · 2017-07-10T23:58:15Z

/retest

luxas · 2017-07-11T08:08:23Z

/retest

Automatic merge from submit-queue godep-save.sh: add workaround and more instructions Fixes #48593, hit again in #47232 (comment).

gyliu513 · 2017-07-11T22:59:33Z

/retest

gyliu513 · 2017-07-12T02:47:50Z

ping @luxas and @mikedanese for lgtm and approve

luxas · 2017-07-12T06:06:07Z

/lgtm

k8s-github-robot · 2017-07-12T06:06:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gyliu513, k82cn, luxas, mikedanese
We suggest the following additional approver: jregan

Assign the PR to them by writing /assign @jregan in a comment when ready.

Associated issue: 47205

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

luxas · 2017-07-12T06:09:01Z

As everyone here is happy with this, I approved as well

k8s-github-robot · 2017-07-12T07:08:20Z

Automatic merge from submit-queue

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2017

k8s-github-robot assigned caesarxuchao and pmorie Jun 9, 2017

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 9, 2017

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 9, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2017

luxas mentioned this pull request Jul 5, 2017

Move "mesos/docker" cloud provide into kube-mesos-framework. #34924

Closed

k8s-ci-robot assigned k82cn Jul 6, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2017

gyliu513 force-pushed the remove-mesos-cp branch from 47a77fc to 0ec9e3c Compare July 6, 2017 05:40

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2017

Removed mesos as cloud provider from Kubernetes.

498b034

sttts mentioned this pull request Jul 10, 2017

godep-save.sh: add workaround and more instructions #48685

Merged

Removed old mesos deps.

9ef8266

gyliu513 force-pushed the remove-mesos-cp branch from 0ec9e3c to 9ef8266 Compare July 10, 2017 07:49

k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2017

k8s-github-robot pushed a commit that referenced this pull request Jul 11, 2017

Merge pull request #48685 from sttts/sttts-godep-symlink-workaround

112d741

Automatic merge from submit-queue godep-save.sh: add workaround and more instructions Fixes #48593, hit again in #47232 (comment).

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2017

luxas added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2017

k8s-github-robot merged commit a3430ad into kubernetes:master Jul 12, 2017

gyliu513 deleted the remove-mesos-cp branch July 12, 2017 07:10

Removed mesos as cloud provider from Kubernetes. #47232

Removed mesos as cloud provider from Kubernetes. #47232

Conversation

gyliu513 commented Jun 9, 2017 • edited

dims commented Jun 9, 2017

luxas commented Jun 9, 2017

gyliu513 commented Jun 9, 2017 • edited

gyliu513 commented Jun 9, 2017

gyliu513 commented Jun 9, 2017

luxas commented Jun 9, 2017

luxas commented Jun 9, 2017

k82cn commented Jun 9, 2017

luxas commented Jun 24, 2017

k82cn commented Jun 25, 2017

gyliu513 commented Jul 5, 2017

luxas commented Jul 5, 2017

k82cn commented Jul 5, 2017

luxas commented Jul 5, 2017

k82cn commented Jul 5, 2017

k82cn commented Jul 6, 2017

k82cn commented Jul 6, 2017

gyliu513 commented Jul 10, 2017

k82cn commented Jul 10, 2017

sttts commented Jul 10, 2017

gyliu513 commented Jul 10, 2017

sttts commented Jul 10, 2017

sttts commented Jul 10, 2017

gyliu513 commented Jul 10, 2017

luxas commented Jul 10, 2017

sttts commented Jul 10, 2017

mikedanese commented Jul 10, 2017

sttts commented Jul 10, 2017

k82cn commented Jul 10, 2017

gyliu513 commented Jul 10, 2017

luxas commented Jul 11, 2017

gyliu513 commented Jul 11, 2017

gyliu513 commented Jul 12, 2017

luxas commented Jul 12, 2017

k8s-github-robot commented Jul 12, 2017

luxas commented Jul 12, 2017

k8s-github-robot commented Jul 12, 2017

gyliu513 commented Jun 9, 2017 •

edited

gyliu513 commented Jun 9, 2017 •

edited