Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad check in node e2e tests for GPUs. #47321

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Fix bad check in node e2e tests for GPUs. #47321

merged 1 commit into from
Jun 13, 2017

Conversation

rohitagarwal003
Copy link
Member

When no nvidia device was attached, the -ne check had a syntax error:

sh: -ne: argument expected

This resulted in Success being echoed and the test passing incorrectly.
This was found while debugging issue #47216

/release-note-none
/sig node
/area node-e2e
/kind bug

@rohitagarwal003
Fix bad check in node e2e tests for GPUs.
f7a5634 
When no nvidia device was attached, the -ne check had a syntax error:

    sh: -ne: argument expected

This resulted in 'Success' being echoed and the test passing incorrectly.
This was found while debugging issue kubernetes#47216
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/node-e2e kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mindprince. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 12, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 12, 2017
@rohitagarwal003
Copy link
Member Author

/unassign @tmrts @yujuhong
/assign @vishh

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 12, 2017
@k8s-ci-robot k8s-ci-robot assigned vishh and unassigned tmrts and yujuhong Jun 12, 2017
@vishh
Copy link
Contributor

vishh commented Jun 12, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mindprince, vishh

Associated issue: 47216

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2017
@vishh
Copy link
Contributor

vishh commented Jun 12, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 12, 2017
@rohitagarwal003 rohitagarwal003 mentioned this pull request Jun 12, 2017
Closed
@rohitagarwal003
Copy link
Member Author

/retest

@rohitagarwal003
Copy link
Member Author

@vishh Can you add milestone 1.7 to this?

@vishh vishh added this to the v1.7 milestone Jun 12, 2017
@vishh vishh added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jun 12, 2017
@rohitagarwal003
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4a8c245 into kubernetes:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/node-e2e cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohitagarwal003 @k8s-ci-robot @vishh @k8s-github-robot @tmrts @yujuhong