Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nginx] Run nginx ingress test in slow suite #47369

Merged
merged 1 commit into from
Jun 12, 2017
Merged

[Nginx] Run nginx ingress test in slow suite #47369

merged 1 commit into from
Jun 12, 2017

Conversation

nicksardo
Copy link
Contributor

Fixes #47362
I'm told that by adding "[Slow]" to the test name, it'll only be ran in the slow test suite.

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 12, 2017
@nicksardo
Copy link
Contributor Author

/assign @MrHohn
/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jun 12, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@dchen1107 dchen1107 added this to the v1.7 milestone Jun 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, nicksardo

Associated issue: 47362

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dchen1107 dchen1107 added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jun 12, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2017
@MrHohn
Copy link
Member

MrHohn commented Jun 12, 2017

Thanks!

@dchen1107
Copy link
Member

@saad-ali The build cop cc/ @kubernetes/kubernetes-release-managers

@dchen1107
Copy link
Member

I manually merge this one to fix the pull-kubernetes-e2e-gce-etcd3.

@dchen1107 dchen1107 merged commit 139d7ee into kubernetes:master Jun 12, 2017
@nicksardo nicksardo deleted the nginx-ingress-slow branch January 12, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marun marun

@gmarek gmarek

@dchen1107 dchen1107

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nicksardo @dchen1107 @k8s-github-robot @MrHohn @marun @gmarek @k8s-ci-robot