Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GPU e2e tests. #47467

Merged
merged 3 commits into from Jun 14, 2017
Merged

Update GPU e2e tests. #47467

merged 3 commits into from Jun 14, 2017

Conversation

rohitagarwal003
Copy link
Member

  • Use nvidia driver installer from external repo.

    That installer decouples itself from COS image version (as long as the
    image version is newer than cos-stable-59-9460-60-0).

    A separate commit in the test-infra repo will update the cos version
    used for this test to cos-stable-59-9460-60-0.

  • Use cos-stable-59-9460-60-0 and newer installer for GPU node e2e tests.

This is to enable #47388.

This supercedes #47091.

Release note:

NONE

/sig node

@rohitagarwal003
Use nvidia driver installer from external repo.
9fed768 
That installer decouples itself from COS image version (as long as the
image version is newer than cos-stable-59-9460-60-0).

A separate commit in the test-infra repo will update the cos version
used for this test to cos-stable-59-9460-60-0.
@rohitagarwal003
Use cos-stable-59-9460-60-0 and newer installer for GPU node e2e tests.
9c0bf19
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mindprince. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 13, 2017
@rohitagarwal003
Copy link
Member Author

cc - @vishh

rohitagarwal003 added a commit to rohitagarwal003/test-infra that referenced this pull request Jun 13, 2017
@rohitagarwal003
Update cos image used by GPU e2e tests on GCE.
47eeeac 
This is required by the updated installer added in kubernetes/kubernetes#47467
@rohitagarwal003 rohitagarwal003 mentioned this pull request Jun 13, 2017
Merged
vishh
vishh reviewed Jun 13, 2017
View reviewed changes
test/e2e/nvidia-gpus.go Outdated
data := generated.ReadOrDie(fileName)
framework.Logf("Parsing ds from %v", url)

response, err := http.Get(url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we retry a few times just to avoid spurious network issues or github serving issues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added retries.

@vishh
Copy link
Contributor

vishh commented Jun 13, 2017

Just one comment. Otherwise LGTM

@vishh vishh assigned vishh and unassigned ncdc and enisoc Jun 13, 2017
@vishh
Copy link
Contributor

vishh commented Jun 13, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2017
@vishh vishh added this to the v1.7 milestone Jun 13, 2017
@dchen1107
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2017
@rohitagarwal003 rohitagarwal003 mentioned this pull request Jun 13, 2017
Merged
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2017
@vishh
Copy link
Contributor

vishh commented Jun 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mindprince, vishh

Associated issue: 47388

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rohitagarwal003
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9fff13b into kubernetes:master Jun 14, 2017
@rohitagarwal003
Copy link
Member Author

Waiting for kubernetes/test-infra#3050 to get merged.

@rohitagarwal003 rohitagarwal003 mentioned this pull request Jun 14, 2017
Merged
rohitagarwal003 added a commit to rohitagarwal003/kubernetes that referenced this pull request Jun 16, 2017
@rohitagarwal003
Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0.
3a86c97 
- It contains a fix for ipaliasing.
- It contains a fix which decouples GPU driver installation from kernel
version.

Remove dead code that has now moved to another repo as part of kubernetes#47467
k8s-github-robot pushed a commit that referenced this pull request Jun 17, 2017
Merge pull request #47530 from mindprince/issue-47388-remove-dead-code
b6faf34 
Automatic merge from submit-queue (batch tested with PRs 47530, 47679)

Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0.

Remove dead code that has now moved to another repo as part of #47467

**Release note**:
```release-note
NONE
```

/sig node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh left review comments

Assignees

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rohitagarwal003 @k8s-ci-robot @vishh @dchen1107 @k8s-github-robot @ncdc @enisoc