Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCE] Bump GLBC version to 0.9.4 #47468

Merged
merged 1 commit into from
Jun 14, 2017
Merged

[GCE] Bump GLBC version to 0.9.4 #47468

merged 1 commit into from
Jun 14, 2017

Conversation

nicksardo
Copy link
Contributor

Fixes #47273
/assign @bowei
/sig network
/area platform/gce

Release note:

Bump GLBC version to 0.9.4

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/platform/gce labels Jun 13, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2017
bowei
bowei approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bowei
Copy link
Member

bowei commented Jun 13, 2017

@dchen1107 needs 1.7 milestone

@nicksardo
Copy link
Contributor Author

nicksardo commented Jun 13, 2017 •
edited

FYI @ixdy

@nicksardo
Copy link
Contributor Author

/assign @mikedanese
/unassign @roberthbailey

@mikedanese
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2017
@roberthbailey
Copy link
Contributor

Does this need to be added to the 1.7 milestone?

@roberthbailey roberthbailey added this to the v1.7 milestone Jun 14, 2017
@roberthbailey
Copy link
Contributor

It fixes an issue labeled approved-for-milestone so I added the milestone label to the PR.

@ixdy
Copy link
Member

ixdy commented Jun 14, 2017

@nicksardo it looks like 1.5 and 1.6 are also using glbc:0.9.3. Is it safe to cherry-pick the bump to those releases, too?

@nicksardo
Copy link
Contributor Author

Thanks @roberthbailey for the milestone. Was waiting for someone else to apply it...

@ixdy Should be safe for the older versions. I'll cherrypick them after this one is merged.

@ixdy
Copy link
Member

ixdy commented Jun 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese, nicksardo

Associated issue: 47273

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

This was referenced Jun 14, 2017
Closed
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47302, 47389, 47402, 47468, 47459)

@k8s-github-robot k8s-github-robot merged commit 37ed227 into kubernetes:master Jun 14, 2017
@nicksardo nicksardo deleted the gclb-0.9.4 branch January 12, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees

@bowei bowei

@mikedanese mikedanese

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/platform/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nicksardo @bowei @mikedanese @roberthbailey @ixdy @k8s-github-robot @k8s-ci-robot