Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0. #47530

Merged
merged 1 commit into from Jun 17, 2017
Merged

Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0. #47530

merged 1 commit into from Jun 17, 2017

Conversation

rohitagarwal003
Copy link
Member

Remove dead code that has now moved to another repo as part of #47467

Release note:

NONE

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mindprince. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 14, 2017
@vishh
Copy link
Contributor

vishh commented Jun 14, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2017
@dims
Copy link
Member

dims commented Jun 15, 2017

/assign @gmarek @pwittrock

@dims
Copy link
Member

dims commented Jun 15, 2017

/approve

@vishh vishh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2017
@dchen1107
Copy link
Member

cc/ @abgworrall Adam has a pending pr to upgrade cos image to another minor version. Can we collaborate together to include all required fixes?

I am leaving @abgworrall to make the final call here.

@abgworrall
Copy link
Contributor

Oops, yes - I have #47670 on the go, for cos-stable-59-9460-64-0. It contains an important fix for ipaliasing that @bowei is waiting on. Can we get that merged instead ? (It's failing tests right now, but I aim to get it sorted out by end of day ...)

@rohitagarwal003
Copy link
Member Author

@abgworrall I can update this PR to use cos-stable-59-9460-64-0.

@rohitagarwal003
Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0.
3a86c97 
- It contains a fix for ipaliasing.
- It contains a fix which decouples GPU driver installation from kernel
version.

Remove dead code that has now moved to another repo as part of kubernetes#47467
@rohitagarwal003 rohitagarwal003 changed the title Use cos-stable-59-9460-60-0 instead of cos-beta-59-9460-20-0. Use cos-stable-59-9460-64-0 instead of cos-beta-59-9460-20-0. Jun 16, 2017
@rohitagarwal003
Copy link
Member Author

Updated to include #47670

@abgworrall abgworrall mentioned this pull request Jun 16, 2017
Closed
@abgworrall
Copy link
Contributor

@bowei , this is now the PR that should precede your tests getting re-enabled.

@rohitagarwal003
Copy link
Member Author

@abgworrall Can you add milestone 1.7 to this, so that this gets merged.

@abgworrall
Copy link
Contributor

abgworrall commented Jun 16, 2017 via email

@krzyzacy
Copy link
Member

/cc @dchen1107

@vishh vishh added this to the v1.7 milestone Jun 16, 2017
@vishh
Copy link
Contributor

vishh commented Jun 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@dchen1107 dchen1107 self-assigned this Jun 17, 2017
@dchen1107 dchen1107 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2017
@dchen1107
Copy link
Member

/lgtm

Ok, I changed my mind. I discussed with @abgworrall earlier to wait for Monday morning to merge this pr since it changes the default COS image which most tests are running on, and there are many pending pr waiting for being merged. But I looked at the testgrid which @abgworrall ran with, cos-stable-59-9460-64-0 looks pretty good. Thanks!

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dims, mindprince, vishh

Associated issue: 47467

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 17, 2017 •
edited

@mindprince: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 3a86c97 link @k8s-bot pull-kubernetes-unit test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47530, 47679)

@k8s-github-robot k8s-github-robot merged commit b6faf34 into kubernetes:master Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@vishh vishh

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@rohitagarwal003 @k8s-ci-robot @vishh @dims @dchen1107 @abgworrall @krzyzacy @k8s-github-robot @gmarek @pwittrock