Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Juju kubernetes-master idle status never being set #47674

Merged
merged 1 commit into from Jun 17, 2017
Merged

Fix Juju kubernetes-master idle status never being set #47674

merged 1 commit into from Jun 17, 2017

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Jun 16, 2017

What this PR does / why we need it:

This fixes a problem with the kubernetes-master charm where the "Kubernetes master running." status message never gets set.

This happens because the kube-api-endpoint.connected state that it's waiting for doesn't exist. The state we need is kube-api-endpoint.available as seen here.

Additionally, we need to add the relation arguments to idle_status so it doesn't break when called.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47676

Special notes for your reviewer:

Release note:

Fix Juju kubernetes-master idle status never being set

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 16, 2017
@lazypower
Copy link
Contributor

/approve

@lazypower
Copy link
Contributor

/assign @chuckbutler

@eparis
Copy link
Contributor

eparis commented Jun 16, 2017

@k8s-bot ok to test
/release-note-none
/approve

I'll let someone who knows juju do the lgtm Do we NEED this in 1.7? If so I think you need to open an issue.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 16, 2017
@lazypower
Copy link
Contributor

@eparis its a status message fix, low priority papercut.

@lazypower
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cynerva, chuckbutler, eparis

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2017
@Cynerva
Copy link
Contributor Author

Cynerva commented Jun 16, 2017

I went ahead and opened an issue and updated the PR to reference it.

@eparis eparis added this to the v1.7 milestone Jun 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47626, 47674, 47683, 47290, 47688)

@k8s-github-robot k8s-github-robot merged commit 260fcaf into kubernetes:master Jun 17, 2017
@Cynerva Cynerva deleted the gkk/missing-idle-status branch June 19, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Juju kubernetes-master idle status is never set
5 participants