New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Juju kubernetes-master idle status never being set #47674
Fix Juju kubernetes-master idle status never being set #47674
Conversation
Hi @Cynerva. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
/assign @chuckbutler |
@k8s-bot ok to test I'll let someone who knows juju do the lgtm Do we NEED this in 1.7? If so I think you need to open an issue. |
@eparis its a status message fix, low priority papercut. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Cynerva, chuckbutler, eparis No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
I went ahead and opened an issue and updated the PR to reference it. |
Automatic merge from submit-queue (batch tested with PRs 47626, 47674, 47683, 47290, 47688) |
What this PR does / why we need it:
This fixes a problem with the kubernetes-master charm where the "Kubernetes master running." status message never gets set.
This happens because the
kube-api-endpoint.connected
state that it's waiting for doesn't exist. The state we need iskube-api-endpoint.available
as seen here.Additionally, we need to add the relation arguments to idle_status so it doesn't break when called.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #47676Special notes for your reviewer:
Release note: