Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded CIDR in the validation_test #47751

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Fix hardcoded CIDR in the validation_test #47751

merged 1 commit into from
Jun 21, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Jun 19, 2017 •
edited by enisoc

xref: #47379

none

@bowei
Fix hardcoded CIDR in the validation_test
15c5509 
The ideal fix is to not hardcode these values.

fixes kubernetes#47479

Cherrypick of 1ed4afc from 1.7.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2017
@bowei bowei mentioned this pull request Jun 19, 2017
Closed
@dchen1107 dchen1107 self-assigned this Jun 19, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2017
@dchen1107 dchen1107 added this to the v1.7 milestone Jun 19, 2017
@enisoc enisoc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2017
@enisoc enisoc modified the milestones: v1.6, v1.7 Jun 19, 2017
@enisoc enisoc added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei, dchen1107

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2017
@dchen1107
Copy link
Member

/test pull-kubernetes-e2e-gce-etcd3

@enisoc enisoc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2c123c8 into kubernetes:release-1.6 Jun 21, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@bowei bowei deleted the fix-ip-range-2 branch September 5, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bowei @dchen1107 @k8s-github-robot @k8s-cherrypick-bot @enisoc @k8s-ci-robot