Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for nvidiaGPUManager initialization #47918

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Add unit test coverage for nvidiaGPUManager initialization #47918

merged 1 commit into from
Jul 1, 2017

Conversation

jiayingz
Copy link
Contributor

Part of #47750

NONE

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 22, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jiayingz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 22, 2017
@jiayingz
Copy link
Contributor Author

CLA should be signed now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 22, 2017
@jiayingz
Copy link
Contributor Author

/assign @vishh

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2017
vishh
vishh approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@vishh vishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2017
@vishh
Copy link
Contributor

vishh commented Jun 23, 2017

/approve

@vishh
Copy link
Contributor

vishh commented Jun 23, 2017

/test all

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2017
@cmluciano
Copy link

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 28, 2017
@cmluciano
Copy link

@jiayingz The bazel build is claiming a merge conflict CONFLICT (content): Merge conflict in pkg/kubelet/gpu/nvidia/nvidia_gpu_manager_test.go

@cmluciano
Copy link

/assign

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2017
@jiayingz
Copy link
Contributor Author

/retest

rohitagarwal003
rohitagarwal003 suggested changes Jun 28, 2017
View reviewed changes
Copy link
Member

@rohitagarwal003 rohitagarwal003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/kubelet/gpu/nvidia/BUILD needs to be updated with a new test dependency on:

//pkg/kubelet/dockershim/libdocker:go_default_library

pkg/kubelet/gpu/nvidia/nvidia_gpu_manager_test.go Outdated
"testing"

"github.com/stretchr/testify/assert"

"k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/kubernetes/pkg/kubelet/dockershim/libdocker"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run go fmt on this file. This seems unordered.

@rohitagarwal003
Copy link
Member

/assign

cmluciano
cmluciano reviewed Jun 28, 2017
View reviewed changes
pkg/kubelet/gpu/nvidia/nvidia_gpu_manager_test.go Outdated

err2 := testGpuManager2.Start()
if err2 != nil {
gpus := reflect.ValueOf(testGpuManager2).Elem().FieldByName("allGPUs").Len()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a note of how many we do expect as a comment? Also will testGpuManager2.Start try to go through the discovery logic or do we want to hardcode it more?

@jiayingz jiayingz mentioned this pull request Jun 28, 2017
Closed
@jiayingz jiayingz force-pushed the unit-test branch 2 times, most recently from 7aa9a3a to 38c5016 Compare June 28, 2017 22:13
@cmluciano
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, jiayingz, vishh

Associated issue: 47750

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47918, 47964, 48151, 47881, 48299)

@k8s-github-robot k8s-github-robot merged commit 57dddce into kubernetes:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

@rohitagarwal003 rohitagarwal003 rohitagarwal003 requested changes

@vishh vishh vishh approved these changes

Assignees

@rohitagarwal003 rohitagarwal003

@resouer resouer

@cmluciano cmluciano

@vishh vishh

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jiayingz @k8s-ci-robot @vishh @cmluciano @rohitagarwal003 @k8s-github-robot @resouer @dchen1107