-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add level for print flags #47945
add level for print flags #47945
Conversation
Signed-off-by: sakeven <jc5930@sina.cn>
Hi @sakeven. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
/cc @kubernetes/kubernetes-release-managers Mark 1.7 because this fixes a 1.7 issue #47932. |
/retest |
test OK in my environment. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, sakeven Associated issue: 47932 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 47883, 47179, 46966, 47982, 47945) |
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7. #47986: Change service port to avoid collision #47152: Kubelet doesn't override addrs from Cloud provider #47860: Make fluentd log to stdio instead of a dedicated file #47945: add level for print flags #47961: Bumped Heapster to v1.4.0-beta.0 #47986: Change service port to avoid collision #47993: Use a different env var to enable the ip-masq-agent addon. We #48012: Extending timeout waiting for delete node to become ready #48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
Signed-off-by: sakeven jc5930@sina.cn
What this PR does / why we need it:
It's ugly to print all flags whenever.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #47932
Special notes for your reviewer:
Release note: