Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending timeout waiting for delete node to become ready before the test ends. #48012

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Extending timeout waiting for delete node to become ready before the test ends. #48012

merged 1 commit into from
Jun 27, 2017

Conversation

verult
Copy link
Contributor

@verult verult commented Jun 24, 2017 •
edited

What this PR does / why we need it: It seems to take longer than 5 minutes for the node to recover. Changing the timeout to 10 minutes.
This is an extension of PR #46746

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #48008

/release-note-none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @verult. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verult
Copy link
Contributor Author

verult commented Jun 24, 2017

/assign @msau42
/cc @dchen1107

Please mark as part of the 1.7 milestone, thanks!

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 24, 2017
@verult
Copy link
Contributor Author

verult commented Jun 24, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 24, 2017
@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2017
@msau42
Copy link
Member

msau42 commented Jun 24, 2017

/test pull-kubernetes-bazel
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@marun marun requested a review from saad-ali June 26, 2017 20:04
@dchen1107
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, msau42, verult

Associated issue: 46746

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2017
@dchen1107
Copy link
Member

Here is my concern for this: The default timeout value for node controller switch the node status from READY to UNKNOWN is 5mins. Now you change the test node status timeout value to 10mins. This might fix the flaky test, but obviously indicates to me this is a bad integration test.

Anyway, I approve this one for fixing the flaky test for now. We need to rewrite those tests.

cc/ @kubernetes/kubernetes-release-managers

@dchen1107 dchen1107 added this to the v1.7 milestone Jun 26, 2017
@dchen1107 dchen1107 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jun 26, 2017
@dchen1107
Copy link
Member

@verult Can you create a cherrypick pr for this?

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48012, 47443, 47702, 47178)

@k8s-github-robot k8s-github-robot merged commit 1258a7a into kubernetes:master Jun 27, 2017
@caesarxuchao
Copy link
Member

I'll do a batch cherrypick.

@caesarxuchao caesarxuchao mentioned this pull request Jun 27, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
Merge pull request #48146 from caesarxuchao/automated-cherry-pick-of-…
625cfe5 
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085

Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7.

#47986: Change service port to avoid collision
#47152: Kubelet doesn't override addrs from Cloud provider
#47860: Make fluentd log to stdio instead of a dedicated file
#47945: add level for print flags
#47961: Bumped Heapster to v1.4.0-beta.0
#47986: Change service port to avoid collision
#47993: Use a different env var to enable the ip-masq-agent addon. We
#48012: Extending timeout waiting for delete node to become ready
#48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@dchen1107 dchen1107

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
8 participants
@verult @k8s-ci-robot @cblecker @msau42 @dchen1107 @k8s-github-robot @caesarxuchao @k8s-cherrypick-bot