[e2e-ingress] Get node tag from instance under GKE #48309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
MrHohn
force-pushed
the
e2e-fix-ingress-tag
branch
from
c01dea7
to
419d1d2
Compare
MrHohn
commented
Jun 30, 2017
test/e2e/framework/firewall_util.go
Outdated
| func GetNodeTags(c clientset.Interface, cloudConfig CloudConfig) []string { | ||
| nodes := GetReadySchedulableNodesOrDie(c) | ||
| Expect(len(nodes.Items) > 0).Should(BeTrue()) | ||
| return GetInstanceTags(cloudConfig, nodes.Items[0].Name).Items |
There was a problem hiding this comment.
@nicksardo Changed to return all tags instead.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
Thanks! /assign @bowei |
bowei
reviewed
Jul 5, 2017
test/e2e/framework/firewall_util.go
Outdated
| // GetNodeTags gets k8s node tag from one of the nodes | ||
| func GetNodeTags(c clientset.Interface, cloudConfig CloudConfig) []string { | ||
| nodes := GetReadySchedulableNodesOrDie(c) | ||
| Expect(len(nodes.Items) > 0).Should(BeTrue()) |
There was a problem hiding this comment.
If len(nodes.Items) == 0, can't we just return []string{}?
There was a problem hiding this comment.
Sounds good, added logging for 0 node and return []string{}.
MrHohn
force-pushed
the
e2e-fix-ingress-tag
branch
from
419d1d2
to
532a9d7
Compare
k8s-github-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, bowei, nicksardo Associated issue: 48167 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Making ingress CI green again.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #48167Special notes for your reviewer:
/assign @nicksardo
Release note: