Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup lint errors in the pkg/kubelet/server/... directory #48313

Merged
merged 1 commit into from
Jul 1, 2017

Conversation

timstclair
Copy link

Cleanup some issues that were found while experimenting with https://github.com/alecthomas/gometalinter on the pkg/kubelet/server/... directories.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 30, 2017
@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 30, 2017
@yujuhong
Copy link
Contributor

This is awesome! :-) What linters did you configure gometalinter to use?

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timstclair, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2017
@timstclair
Copy link
Author

I used:

gometalinter --disable=errcheck --disable=golint --exclude=.*\.pb\.go k8s.io/kubernetes/pkg/kubelet/server/... | sort

We don't do a good job with doc comments, so golint outputs a ton of comments complaints. Errcheck looks for ignored errors, but when I went through the results, most of the cases seemed like legitimate places to ignore the errors. The linter also caught #48297, but I didn't want to fix it in this PR :)

@timstclair
Copy link
Author

/test pull-kubernetes-e2e-gce-etcd3 issue #42086

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48317, 48313, 48351, 48357, 48115)

@k8s-github-robot k8s-github-robot merged commit 21038e3 into kubernetes:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants